From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Glen Choo via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Huang Zou <huang.zou@schrodinger.com>,
Josh Steadmon <steadmon@google.com>,
Glen Choo <chooglen@google.com>
Subject: Re: [PATCH v2] pull: only pass '--recurse-submodules' to subcommands
Date: Wed, 11 May 2022 15:34:37 -0700 [thread overview]
Message-ID: <xmqqzgjnhf5u.fsf@gitster.g> (raw)
In-Reply-To: <deafd5db-6303-46b3-a5d5-b4117ba16781@gmail.com> (Philippe Blain's message of "Wed, 11 May 2022 18:30:27 -0400")
Philippe Blain <levraiphilippeblain@gmail.com> writes:
>> pull: only pass '--recurse-submodules' to subcommands
>>
>> Thanks for the debugging help :)
>>
>> Changes since v1:
>>
>> * add a test that actually tests the precedence of the config values
>> * I've kept the previous test; it has always worked, but it still
>> seems like a useful smoke test
>> * reworded the commit message slightly
>
> Thanks, this version looks good to me. I don't feel to strongly about the
> title either, so as you wish :)
Perhaps
pull: do not let submodule.recurse override fetch.recurseSubmodules
more clearly expresses what it wants to do (not passing the command
line option is "how" we achieve that goal)?
next prev parent reply other threads:[~2022-05-11 22:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 23:27 [PATCH] pull: only pass '--recurse-submodules' to subcommands Glen Choo via GitGitGadget
2022-05-10 0:09 ` Junio C Hamano
2022-05-10 0:44 ` Junio C Hamano
2022-05-10 13:28 ` Philippe Blain
2022-05-10 18:27 ` Glen Choo
2022-05-10 18:43 ` Glen Choo
2022-05-10 19:25 ` [PATCH v2] " Glen Choo via GitGitGadget
2022-05-11 22:30 ` Philippe Blain
2022-05-11 22:34 ` Junio C Hamano [this message]
2022-05-11 22:35 ` Philippe Blain
2022-05-11 23:21 ` Glen Choo
2022-05-12 20:37 ` Junio C Hamano
2022-05-11 23:42 ` [PATCH v3] pull: do not let submodule.recurse override fetch.recurseSubmodules Glen Choo via GitGitGadget
2022-05-12 20:38 ` Junio C Hamano
2022-05-12 23:35 ` Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgjnhf5u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=huang.zou@schrodinger.com \
--cc=levraiphilippeblain@gmail.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).