git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Glen Choo <chooglen@google.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Cc: Glen Choo via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Huang Zou <huang.zou@schrodinger.com>,
	Josh Steadmon <steadmon@google.com>
Subject: Re: [PATCH v2] pull: only pass '--recurse-submodules' to subcommands
Date: Wed, 11 May 2022 16:21:55 -0700	[thread overview]
Message-ID: <kl6ltu9vy7sc.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <6e59a82c-22cc-8f0c-f7f7-94da59e8da89@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

> Le 2022-05-11 à 18:34, Junio C Hamano a écrit :
>> Philippe Blain <levraiphilippeblain@gmail.com> writes:
>> 
>>>>     pull: only pass '--recurse-submodules' to subcommands
>>>>     
>>>>     Thanks for the debugging help :)
>>>>     
>>>>     Changes since v1:
>>>>     
>>>>      * add a test that actually tests the precedence of the config values
>>>>        * I've kept the previous test; it has always worked, but it still
>>>>          seems like a useful smoke test
>>>>      * reworded the commit message slightly
>>>
>>> Thanks, this version looks good to me. I don't feel to strongly about the 
>>> title either, so as you wish :)
>> 
>> Perhaps
>> 
>> 	pull: do not let submodule.recurse override fetch.recurseSubmodules
>> 
>> more clearly expresses what it wants to do (not passing the command
>> line option is "how" we achieve that goal)?
>> 
>
> I like that title, yes.

Hm, yes that makes more sense. The commit message leads with the bug, so
it's more consistent to mention the bug in the title too.

It's arguably more _correct_ to say that passing only the CLI option is
the desired result, and we just so happen to be fixing a bug along the
way. But meh, the bug is roughly 90% [1] of the motivation for making
this patch, so leading with the bug is ok.

Will reroll.

[1] The other 10% or so is some upcoming work with `git rebase
--recurse-submodules` and supporting that in `git pull --rebase
--recurse-submodules` :)

  reply	other threads:[~2022-05-11 23:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 23:27 [PATCH] " Glen Choo via GitGitGadget
2022-05-10  0:09 ` Junio C Hamano
2022-05-10  0:44 ` Junio C Hamano
2022-05-10 13:28 ` Philippe Blain
2022-05-10 18:27   ` Glen Choo
2022-05-10 18:43   ` Glen Choo
2022-05-10 19:25 ` [PATCH v2] " Glen Choo via GitGitGadget
2022-05-11 22:30   ` Philippe Blain
2022-05-11 22:34     ` Junio C Hamano
2022-05-11 22:35       ` Philippe Blain
2022-05-11 23:21         ` Glen Choo [this message]
2022-05-12 20:37           ` Junio C Hamano
2022-05-11 23:42   ` [PATCH v3] pull: do not let submodule.recurse override fetch.recurseSubmodules Glen Choo via GitGitGadget
2022-05-12 20:38     ` Junio C Hamano
2022-05-12 23:35       ` Philippe Blain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kl6ltu9vy7sc.fsf@chooglen-macbookpro.roam.corp.google.com \
    --to=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=huang.zou@schrodinger.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=steadmon@google.com \
    --subject='Re: [PATCH v2] pull: only pass '\''--recurse-submodules'\'' to subcommands' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).