From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance
Date: Tue, 31 Oct 2017 14:48:02 +0900 [thread overview]
Message-ID: <xmqqy3nrzx4d.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171030205522.hur26cumwusk7wwa@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Mon, 30 Oct 2017 13:55:22 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> This feature was introduced as an experimental feature into Git for
>> Windows v2.11.0(2) and has been tested ever since. I feel it is
>> well-tested enough that it can be integrated into core Git.
>
> Can this rationale go in the commit messages?
>
> Actually I wouldn't mind if this were all a single patch, with such a
> rationale in the commit message.
>
> The patches' concept seems sane. I haven't looked closely at the
> implementation.
+1.
next prev parent reply other threads:[~2017-10-31 5:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 17:10 [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance Johannes Schindelin
2017-10-30 17:10 ` [PATCH 1/3] mingw: add experimental feature to redirect standard handles Johannes Schindelin
2017-10-30 17:10 ` [PATCH 2/3] mingw: special-case GIT_REDIRECT_STDERR=2>&1 Johannes Schindelin
2017-10-30 17:10 ` [PATCH 3/3] mingw: document the experimental standard handle redirection Johannes Schindelin
2017-10-30 18:58 ` Eric Sunshine
2017-10-31 17:08 ` Johannes Schindelin
2017-11-01 4:58 ` Junio C Hamano
2017-11-01 16:37 ` Johannes Schindelin
2017-11-02 1:31 ` Junio C Hamano
2017-11-02 17:20 ` Johannes Schindelin
2017-11-03 1:50 ` Junio C Hamano
2017-11-03 11:51 ` Johannes Schindelin
2017-10-30 20:55 ` [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance Jonathan Nieder
2017-10-31 5:48 ` Junio C Hamano [this message]
2017-10-31 17:12 ` Johannes Schindelin
2017-10-31 18:09 ` Jonathan Nieder
2017-11-01 17:07 ` Johannes Schindelin
2017-11-01 17:17 ` Stefan Beller
2017-11-01 17:10 ` [PATCH v2 " Johannes Schindelin
2017-11-01 17:10 ` [PATCH v2 1/3] mingw: add experimental feature to redirect standard handles Johannes Schindelin
2017-11-01 17:10 ` [PATCH v2 2/3] mingw: optionally redirect stderr/stdout via the same handle Johannes Schindelin
2017-11-01 17:10 ` [PATCH v2 3/3] mingw: document the standard handle redirection Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3nrzx4d.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).