From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance
Date: Wed, 1 Nov 2017 18:07:25 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1711011737460.6482@virtualbox> (raw)
In-Reply-To: <20171031180933.styinoik4npmd53b@aiede.mtv.corp.google.com>
Hi Jonahtan,
On Tue, 31 Oct 2017, Jonathan Nieder wrote:
> Johannes Schindelin wrote:
> > On Mon, 30 Oct 2017, Jonathan Nieder wrote:
>
> >> Can this rationale go in the commit messages?
> >
> > I thought I had done exactly that in 1/3...
>
> Okay, I'll be more specific. This cover letter includes some
> information about the rationale and motivation for the series. That's
> great: it makes reading the patches easier. But TBH I'd rather that
> it hadn't included that information at all, since if it said "see
> patch 1/3 for rationale" then I could save the trouble of reading the
> same information twice.
Alas, I am the exact opposite. You see, I am seriously short on time, and
if the cover letter of a patch series leaves everything about the changes
unclear, I throw my laptop out the window (actually, I suppress the urge
and just delete the mail thread in my mail reader) and move to the next
mail.
It sounds a bit stupid to cater to myself in patches *I* submit, but I
refuse to believe that there are many people with more time on their hands
than myself (last time I tried to research this, it looked as everybody
has the same 86,400 seconds per day available, give or take the occasional
leap second).
> And unfortunately much of the relevant information is not repeated
> there. The cover letter mentions:
>
> - that Visual Studio is a motivating example
That was actually on purpose. Personally, I want to read the motivation in
the cover letter, and not get distracted by it when reading the commit
logs.
To make you happy, I added this, though.
> - that this is conceptually similar to Unix sockets
To make you happy, I added this, too.
> - that those do not need to be marked as inheritable, as the process
> can simply open the named pipe. No global flags. No problems.
I just added "(and therefore no inherited handles need to be closed)" to
the last sentence of 1/3's commit message that already mentioned this.
> - that this has already seem some testing in Git for Windows (i.e.
> analagous information to what a Tested-by footer would say)
I mentioned this twice, in 1/3's and in 3/3's commit message.
> It is also just more readable than patch 1/3's commit message. That's
> to be expected, since it was written later. My second draft of
> something is often clearer than the first draft.
I took your cue and simply replaced the first paragraph of 1/3's commit
message by the first paragraph of the cover letter.
Ciao,
Dscho
next prev parent reply other threads:[~2017-11-01 17:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 17:10 [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance Johannes Schindelin
2017-10-30 17:10 ` [PATCH 1/3] mingw: add experimental feature to redirect standard handles Johannes Schindelin
2017-10-30 17:10 ` [PATCH 2/3] mingw: special-case GIT_REDIRECT_STDERR=2>&1 Johannes Schindelin
2017-10-30 17:10 ` [PATCH 3/3] mingw: document the experimental standard handle redirection Johannes Schindelin
2017-10-30 18:58 ` Eric Sunshine
2017-10-31 17:08 ` Johannes Schindelin
2017-11-01 4:58 ` Junio C Hamano
2017-11-01 16:37 ` Johannes Schindelin
2017-11-02 1:31 ` Junio C Hamano
2017-11-02 17:20 ` Johannes Schindelin
2017-11-03 1:50 ` Junio C Hamano
2017-11-03 11:51 ` Johannes Schindelin
2017-10-30 20:55 ` [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance Jonathan Nieder
2017-10-31 5:48 ` Junio C Hamano
2017-10-31 17:12 ` Johannes Schindelin
2017-10-31 18:09 ` Jonathan Nieder
2017-11-01 17:07 ` Johannes Schindelin [this message]
2017-11-01 17:17 ` Stefan Beller
2017-11-01 17:10 ` [PATCH v2 " Johannes Schindelin
2017-11-01 17:10 ` [PATCH v2 1/3] mingw: add experimental feature to redirect standard handles Johannes Schindelin
2017-11-01 17:10 ` [PATCH v2 2/3] mingw: optionally redirect stderr/stdout via the same handle Johannes Schindelin
2017-11-01 17:10 ` [PATCH v2 3/3] mingw: document the standard handle redirection Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1711011737460.6482@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).