git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@jeffhostetler.com, git@vger.kernel.org, peff@peff.net,
	me@ttaylorr.com, Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1] config.c: fix msvc compile error
Date: Tue, 24 Jul 2018 11:22:11 -0700	[thread overview]
Message-ID: <xmqqwotkxzn0.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <235ae68c-f764-ba3a-c641-ef5f99507564@drbeat.li> (Beat Bolli's message of "Tue, 24 Jul 2018 20:16:45 +0200")

Beat Bolli <dev+git@drbeat.li> writes:

> Hi Jeff
>
> On 24.07.18 17:30, git@jeffhostetler.com wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>> 
>> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
>> to builtin/config.c to define a new function and a forward declaration
>> for an array of unknown size.  This causes a compile error under MSVC.
>> 
>> Reorder the code to forward declare the function instead of the array.
>
> This was already fixed (differently) in
> <20180705183445.30901-1-dev+git@drbeat.li>.

Thanks for saving me from having to dig the list archive myself.
Yes, it is already applied to the tip of the topic that originally
caused the breakage.

  reply	other threads:[~2018-07-24 18:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 15:30 [PATCH v1] config.c: fix msvc compile error git
2018-07-24 18:07 ` Junio C Hamano
2018-07-24 18:16 ` Beat Bolli
2018-07-24 18:22   ` Junio C Hamano [this message]
2018-07-24 18:26     ` Beat Bolli
2018-07-24 18:50       ` Junio C Hamano
2018-07-24 19:16         ` Beat Bolli
2018-07-24 19:56 ` Taylor Blau
2018-07-25 12:51   ` Jeff Hostetler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwotkxzn0.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dev+git@drbeat.li \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=jeffhost@microsoft.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).