From: Jeff Hostetler <git@jeffhostetler.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1] config.c: fix msvc compile error
Date: Wed, 25 Jul 2018 08:51:52 -0400 [thread overview]
Message-ID: <ca10e6f5-91be-e2a9-19a8-37b67217d134@jeffhostetler.com> (raw)
In-Reply-To: <20180724195637.GA97109@syl.attlocal.net>
On 7/24/2018 3:56 PM, Taylor Blau wrote:
> On Tue, Jul 24, 2018 at 03:30:10PM +0000, git@jeffhostetler.com wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
>> to builtin/config.c to define a new function and a forward declaration
>> for an array of unknown size. This causes a compile error under MSVC.
>
> Thanks for spending time fixing that. fb0dc3bac1 (builtin/config.c:
> support `--type=<type>` as preferred alias for `--<type>`, 2018-04-18)
> is from me, so I owe you an extra thanks for patching up mistakes :-).
>
> As others have noted in this thread, another patch was sent into similar
> effect, which has already been queued, and I agree that we should prefer
> that, since it's further along.
>
>
> Thanks,
> Taylor
>
Yes, the other version is further along. Let's take it.
Jeff
prev parent reply other threads:[~2018-07-25 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 15:30 [PATCH v1] config.c: fix msvc compile error git
2018-07-24 18:07 ` Junio C Hamano
2018-07-24 18:16 ` Beat Bolli
2018-07-24 18:22 ` Junio C Hamano
2018-07-24 18:26 ` Beat Bolli
2018-07-24 18:50 ` Junio C Hamano
2018-07-24 19:16 ` Beat Bolli
2018-07-24 19:56 ` Taylor Blau
2018-07-25 12:51 ` Jeff Hostetler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca10e6f5-91be-e2a9-19a8-37b67217d134@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).