From: Junio C Hamano <email@example.com>
To: Jeff King <firstname.lastname@example.org>
Cc: "Stephen P. Smith" <email@example.com>, firstname.lastname@example.org
Subject: Re: [PATCH 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW
Date: Mon, 09 Sep 2019 12:44:25 -0700 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <20190909172954.GC30470@sigill.intra.peff.net> (Jeff King's message of "Mon, 9 Sep 2019 13:29:54 -0400")
Jeff King <firstname.lastname@example.org> writes:
> On Sun, Sep 08, 2019 at 06:47:11PM -0700, Stephen P. Smith wrote:
>> Remove the reference to the GIT_TEST_DATE_NOW which is done in date.c.
>> The intialization of variable x with the value from GIT_TEST_DATE_NOW
>> is unneeded since x is initalized by skip_prefix().
> It took me a minute to understand what this second sentence meant. I'd
> have actually expected "x" to go away, looking at the diff context.
> Maybe a more clear explanation would be: We can't get rid of the "x"
> variable, since it serves as a generic scratch variable for parsing
> later in the function.
> (I'd also probably have just rolled this into patch 1, but I'm OK with
> it either way).
Thanks for saying everything ;-) I have nothing to add.
next prev parent reply other threads:[~2019-09-09 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 1:47 [PATCH 0/2] Date test code clean-up Stephen P. Smith
2019-09-09 1:47 ` [PATCH 1/2] Quit passing 'now' to date code Stephen P. Smith
2019-09-09 17:28 ` Jeff King
2019-09-09 1:47 ` [PATCH 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW Stephen P. Smith
2019-09-09 17:29 ` Jeff King
2019-09-09 19:44 ` Junio C Hamano [this message]
2019-09-09 18:32 ` [PATCH 0/2] Date test code clean-up Junio C Hamano
2019-09-12 4:11 ` [PATCH v2 " Stephen P. Smith
2019-09-12 4:11 ` [PATCH v2 1/2] Quit passing 'now' to date code Stephen P. Smith
2019-09-12 4:11 ` [PATCH v2 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW Stephen P. Smith
2019-09-13 5:08 ` [PATCH v2 0/2] Date test code clean-up Jeff King
2019-09-13 17:25 ` Junio C Hamano
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).