From: Jeff King <peff@peff.net>
To: "Stephen P. Smith" <ischis2@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Quit passing 'now' to date code
Date: Mon, 9 Sep 2019 13:28:33 -0400 [thread overview]
Message-ID: <20190909172832.GB30470@sigill.intra.peff.net> (raw)
In-Reply-To: <20190909014711.3894-2-ischis2@cox.net>
On Sun, Sep 08, 2019 at 06:47:10PM -0700, Stephen P. Smith wrote:
> As part of a previous patch set, the get_time() function was added to
> date.c eliminating the need to pass a `now` parameter from the test
> code.
I'm glad to see this cleanup. I think it is worth explaining a bit more,
though, why this hunk in particular:
> @@ -103,22 +103,14 @@ static void getnanos(const char **argv)
>
> int cmd__date(int argc, const char **argv)
> {
> - struct timeval now;
> const char *x;
> -
> x = getenv("GIT_TEST_DATE_NOW");
> - if (x) {
> - now.tv_sec = atoi(x);
> - now.tv_usec = 0;
> - }
> - else
> - gettimeofday(&now, NULL);
...is doing the right thing, since it was the site that actually used
the parameters that are being deleted. Maybe something like:
Commit b841d4ff43 (Add `human` format to test-tool, 2019-01-28) added
a get_time() function which allows $GIT_TEST_DATE_NOW in the
environment to override the current time. So we no longer need to
interpret that variable in cmd__date().
Likewise, we can stop passing the "now" parameter down through the
date functions, since nobody uses them. Note that we do need to make
sure all of the previous callers that took a "now" parameter are
correctly using get_time().
which I think explains all of the hunks.
-Peff
next prev parent reply other threads:[~2019-09-09 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 1:47 [PATCH 0/2] Date test code clean-up Stephen P. Smith
2019-09-09 1:47 ` [PATCH 1/2] Quit passing 'now' to date code Stephen P. Smith
2019-09-09 17:28 ` Jeff King [this message]
2019-09-09 1:47 ` [PATCH 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW Stephen P. Smith
2019-09-09 17:29 ` Jeff King
2019-09-09 19:44 ` Junio C Hamano
2019-09-09 18:32 ` [PATCH 0/2] Date test code clean-up Junio C Hamano
2019-09-12 4:11 ` [PATCH v2 " Stephen P. Smith
2019-09-12 4:11 ` [PATCH v2 1/2] Quit passing 'now' to date code Stephen P. Smith
2019-09-12 4:11 ` [PATCH v2 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW Stephen P. Smith
2019-09-13 5:08 ` [PATCH v2 0/2] Date test code clean-up Jeff King
2019-09-13 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909172832.GB30470@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ischis2@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).