git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Stephen P. Smith" <ischis2@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Date test code clean-up
Date: Fri, 13 Sep 2019 10:25:20 -0700	[thread overview]
Message-ID: <xmqqwoecds73.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190913050809.GA28353@sigill.intra.peff.net> (Jeff King's message of "Fri, 13 Sep 2019 01:08:10 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Sep 11, 2019 at 09:11:00PM -0700, Stephen P. Smith wrote:
>
>> Range Diff:
>> 1:  f4170ad553 ! 1:  e2b8322d58 Quit passing 'now' to date code
>> [...]
>
> Thanks, this version addresses all of my concerns from v1 (and overall
> looks good).

Yup, the result of applying these look good.

Thanks, both.

      reply	other threads:[~2019-09-13 17:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09  1:47 [PATCH 0/2] Date test code clean-up Stephen P. Smith
2019-09-09  1:47 ` [PATCH 1/2] Quit passing 'now' to date code Stephen P. Smith
2019-09-09 17:28   ` Jeff King
2019-09-09  1:47 ` [PATCH 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW Stephen P. Smith
2019-09-09 17:29   ` Jeff King
2019-09-09 19:44     ` Junio C Hamano
2019-09-09 18:32 ` [PATCH 0/2] Date test code clean-up Junio C Hamano
2019-09-12  4:11 ` [PATCH v2 " Stephen P. Smith
2019-09-12  4:11   ` [PATCH v2 1/2] Quit passing 'now' to date code Stephen P. Smith
2019-09-12  4:11   ` [PATCH v2 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW Stephen P. Smith
2019-09-13  5:08   ` [PATCH v2 0/2] Date test code clean-up Jeff King
2019-09-13 17:25     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwoecds73.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ischis2@cox.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).