From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Jean-Noël Avila" <jn.avila@free.fr>,
git@vger.kernel.org, "Jiang Xin" <worldhello.net@gmail.com>
Subject: Re: [PATCH v2] l10n: reformat some localized strings for v2.23.0
Date: Mon, 05 Aug 2019 11:49:46 -0700 [thread overview]
Message-ID: <xmqqv9vbmoqd.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190803234522.GA5417@sigill.intra.peff.net> (Jeff King's message of "Sat, 3 Aug 2019 19:45:22 -0400")
Jeff King <peff@peff.net> writes:
>> OPT_STRING('s', "source", &opts.from_treeish, "<tree-ish>",
>> - N_("where the checkout from")),
>> + N_("where the checkout is from")),
>
> I think your original "where to checkout from" is better.
Would we even want to do s/where/which tree-ish/?
> translators, but note that the output will be different. The original
> would be something like:
>
> warning: Fetch normally indicates...
> warning: To re-enable...
>
> where now we'd get:
>
> warning: Fetch normally indicates...
> check has been disabled...
> or run 'git config...
>
> which might be a bit harder to read because the wrapped lines lose the
> prefix. For advise() we nicely pick out the newlines and prefix each
> line individually, but warning(), error(), etc, don't do that. Maybe
> they should.
Yeah, I'd be surprised that nobody thought of doing that, so perhaps
somebody tried and failed with a possible fallout. I do not offhand
see any downside of teaching them to do the prefixing.
For existing multi-line warnings that uses a single call to
warning(), I think the preparer of the message manually indents the
second and subsequent line by a run of SPs to match the screen width
of "warning:" prefix (and expect translators to do the same with
their language), and we need to get rid of that kind of "hack" when
we insert a middle layer between *_builtin() and vreportf() to do
the line chomping to produce output similar to advise() code.
> That's too big for this late in the -rc cycle, I think.
Agreed.
Thanks.
next prev parent reply other threads:[~2019-08-05 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 3:35 [L10N] Kickoff for Git 2.23.0 round #1 Jiang Xin
2019-08-03 10:18 ` [RFC] l10n: fix some typos for v2.23.0 Jean-Noël Avila
2019-08-03 13:50 ` Jiang Xin
2019-08-03 19:59 ` [PATCH v2] l10n: reformat some localized strings " Jean-Noël Avila
2019-08-03 23:45 ` Jeff King
2019-08-04 11:01 ` Jean-Noël AVILA
2019-08-05 4:21 ` Jeff King
2019-08-05 18:49 ` Junio C Hamano [this message]
2019-08-05 21:15 ` Jeff King
2019-08-06 17:19 ` [PATCH v3] " Jean-Noël Avila
2019-08-06 17:54 ` Junio C Hamano
2019-08-06 18:10 ` Jeff King
2019-08-06 19:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9vbmoqd.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
--cc=peff@peff.net \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).