mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: "Jean-Noël AVILA" <>
Cc:, Jiang Xin <>
Subject: Re: [PATCH v2] l10n: reformat some localized strings for v2.23.0
Date: Mon, 5 Aug 2019 00:21:04 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <5200616.dDItsc6b64@cayenne>

On Sun, Aug 04, 2019 at 01:01:51PM +0200, Jean-Noël AVILA wrote:

> This one is not about typos.
> My original fix was more concerning the second sequence, where the
> sentence is broken in the middle, simply for better rendering but this
> does not make sense either, because the lines are too long anyway.

Ah, yeah, the sentence broken over the line is pretty bad for
translation. And I agree the lines are overly long.

> Is it so important that the lines of warning all start with a
> "warning:" prefix?

For some definition of "so". ;) As I said, I think your patch may be the
lesser of two evils, and we should take it until warning() learns to
handle lines breaks better.


  reply	other threads:[~2019-08-05  4:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  3:35 [L10N] Kickoff for Git 2.23.0 round #1 Jiang Xin
2019-08-03 10:18 ` [RFC] l10n: fix some typos for v2.23.0 Jean-Noël Avila
2019-08-03 13:50   ` Jiang Xin
2019-08-03 19:59 ` [PATCH v2] l10n: reformat some localized strings " Jean-Noël Avila
2019-08-03 23:45   ` Jeff King
2019-08-04 11:01     ` Jean-Noël AVILA
2019-08-05  4:21       ` Jeff King [this message]
2019-08-05 18:49     ` Junio C Hamano
2019-08-05 21:15       ` Jeff King
2019-08-06 17:19 ` [PATCH v3] " Jean-Noël Avila
2019-08-06 17:54   ` Junio C Hamano
2019-08-06 18:10     ` Jeff King
2019-08-06 19:45     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).