git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Turner <David.Turner@twosigma.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] clarify documentation for remote helpers
Date: Fri, 30 Aug 2019 10:34:56 -0700	[thread overview]
Message-ID: <xmqqv9uey2tb.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <88d9063060644dd99122bf0933f23fa9@exmbdft7.ad.twosigma.com> (David Turner's message of "Fri, 30 Aug 2019 13:47:23 +0000")

David Turner <David.Turner@twosigma.com> writes:

> I was confused, because I read "a file under GIT_DIR/objects/pack"
> to mean "just the filename".  Some of the things that deal with
> packs take just the filename (e.g. --keep-pack for git repack).
> I'll fix the under under and add $, but I do want to clarify that
> it's the full path.

I think that the phrase wanted to say that the file named with the
option must live under that directory, without any implication that
the directory is used as the base when a relative path is used.  If
the helper MUST give a full pathname and a pathname relative to that
directory is not accepted, it is a good idea to spell it out (also
if it must end with ".keep", that also should be documented---is
there any other restrictions?).

  reply	other threads:[~2019-08-30 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 21:03 [PATCH] clarify documentation for remote helpers David Turner
2019-08-30  4:03 ` Martin Ågren
2019-08-30 13:47   ` David Turner
2019-08-30 17:34     ` Junio C Hamano [this message]
2019-08-30 17:45       ` David Turner
2019-08-30 19:27         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv9uey2tb.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=David.Turner@twosigma.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).