From: "Martin Ågren" <martin.agren@gmail.com>
To: David Turner <dturner@twosigma.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] clarify documentation for remote helpers
Date: Fri, 30 Aug 2019 06:03:08 +0200 [thread overview]
Message-ID: <CAN0heSosCnn5msMX18YPwrKJzWkSWptWSFRunQdLE7T7Lc4-OA@mail.gmail.com> (raw)
In-Reply-To: <20190829210301.18467-1-dturner@twosigma.com>
On Thu, 29 Aug 2019 at 23:06, David Turner <dturner@twosigma.com> wrote:
> -Optionally may output a 'lock <file>' line indicating a file under
> -GIT_DIR/objects/pack which is keeping a pack until refs can be
> -suitably updated.
> +Optionally may output a 'lock <file>' line indicating the full path of
> +a file under under GIT_DIR/objects/pack which is keeping a pack until
> +refs can be suitably updated. The path must end with ".keep".
"under under".
Also -- and I realize this is nothing new in your patch -- "GIT_DIR"
should be prefixed with a '$' and that whole path wrapped in backticks
so it gets monospaced. In total, my suggestion would be
-+a file under under GIT_DIR/objects/pack which is keeping a pack until
++a file under `$GIT_DIR/objects/pack` which is keeping a pack until
Whether what you're saying is actually *true*, sorry, no idea. I just
have those nits above to offer.
Martin
next prev parent reply other threads:[~2019-08-30 4:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 21:03 [PATCH] clarify documentation for remote helpers David Turner
2019-08-30 4:03 ` Martin Ågren [this message]
2019-08-30 13:47 ` David Turner
2019-08-30 17:34 ` Junio C Hamano
2019-08-30 17:45 ` David Turner
2019-08-30 19:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN0heSosCnn5msMX18YPwrKJzWkSWptWSFRunQdLE7T7Lc4-OA@mail.gmail.com \
--to=martin.agren@gmail.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).