mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: David Turner <>
To: Junio C Hamano <>
Cc: "Martin Ågren" <>,
	"Git Mailing List" <>
Subject: RE: [PATCH] clarify documentation for remote helpers
Date: Fri, 30 Aug 2019 17:45:43 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> -----Original Message-----
> From: Junio C Hamano <>
> Sent: Friday, August 30, 2019 1:35 PM
> To: David Turner <>
> Cc: Martin Ågren <>; Git Mailing List
> <>
> Subject: Re: [PATCH] clarify documentation for remote helpers
> David Turner <> writes:
> > I was confused, because I read "a file under GIT_DIR/objects/pack"
> > to mean "just the filename".  Some of the things that deal with packs
> > take just the filename (e.g. --keep-pack for git repack).
> > I'll fix the under under and add $, but I do want to clarify that it's
> > the full path.
> I think that the phrase wanted to say that the file named with the option must
> live under that directory, without any implication that the directory is used as
> the base when a relative path is used.  If the helper MUST give a full pathname
> and a pathname relative to that directory is not accepted, it is a good idea to
> spell it out (also if it must end with ".keep", that also should be documented---
> is there any other restrictions?).

The only other restriction I see is: in order for the connectivity-skipping 
optimization to be used, the file with s/.keep/.idx/, and the corresponding 
pack, must exist.  Do you think that's worth mentioning? It seems to be 
implied by the rest of the text.

  reply	other threads:[~2019-08-30 17:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 21:03 [PATCH] clarify documentation for remote helpers David Turner
2019-08-30  4:03 ` Martin Ågren
2019-08-30 13:47   ` David Turner
2019-08-30 17:34     ` Junio C Hamano
2019-08-30 17:45       ` David Turner [this message]
2019-08-30 19:27         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).