* [PATCH] t7508: avoid non POSIX BRE
@ 2021-08-01 21:53 Carlo Marcelo Arenas Belón
2021-08-02 2:37 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Carlo Marcelo Arenas Belón @ 2021-08-01 21:53 UTC (permalink / raw)
To: git; +Cc: jonathantanmy, Carlo Marcelo Arenas Belón
24c30e0b6 (wt-status: tolerate dangling marks, 2020-09-01) adds a test
that uses a BRE which breaks at least with OpenBSD's grep.
switch to an ERE as it is done for similar checks and while at it, remove
the now obsolete test_i18ngrep call.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
t/t7508-status.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7508-status.sh b/t/t7508-status.sh
index 2b72451ba3..05c6c02435 100755
--- a/t/t7508-status.sh
+++ b/t/t7508-status.sh
@@ -882,7 +882,7 @@ test_expect_success 'status shows detached HEAD properly after checking out non-
git clone upstream downstream &&
git -C downstream checkout @{u} &&
git -C downstream status >actual &&
- test_i18ngrep "HEAD detached at [0-9a-f]\\+" actual
+ grep -E "HEAD detached at [0-9a-f]+" actual
'
test_expect_success 'setup status submodule summary' '
--
2.32.0.826.g286871f41a
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t7508: avoid non POSIX BRE
2021-08-01 21:53 [PATCH] t7508: avoid non POSIX BRE Carlo Marcelo Arenas Belón
@ 2021-08-02 2:37 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2021-08-02 2:37 UTC (permalink / raw)
To: Carlo Marcelo Arenas Belón; +Cc: git, jonathantanmy
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> 24c30e0b6 (wt-status: tolerate dangling marks, 2020-09-01) adds a test
> that uses a BRE which breaks at least with OpenBSD's grep.
>
> switch to an ERE as it is done for similar checks and while at it, remove
> the now obsolete test_i18ngrep call.
Thanks, obviously correct.
I wonder if we can more automate detection of such a bug---it is
unfortunate that it has become very hard to avoid GNUisms as
everybody, even Windows folks, is more likely to be with GNU tools
than BSD tools X-<.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> t/t7508-status.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index 2b72451ba3..05c6c02435 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -882,7 +882,7 @@ test_expect_success 'status shows detached HEAD properly after checking out non-
> git clone upstream downstream &&
> git -C downstream checkout @{u} &&
> git -C downstream status >actual &&
> - test_i18ngrep "HEAD detached at [0-9a-f]\\+" actual
> + grep -E "HEAD detached at [0-9a-f]+" actual
> '
>
> test_expect_success 'setup status submodule summary' '
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-02 2:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-01 21:53 [PATCH] t7508: avoid non POSIX BRE Carlo Marcelo Arenas Belón
2021-08-02 2:37 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).