From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, jonathantanmy@google.com
Subject: Re: [PATCH] t7508: avoid non POSIX BRE
Date: Sun, 01 Aug 2021 19:37:01 -0700 [thread overview]
Message-ID: <xmqqv94oy3le.fsf@gitster.g> (raw)
In-Reply-To: <20210801215300.53781-1-carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Sun, 1 Aug 2021 14:53:00 -0700")
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> 24c30e0b6 (wt-status: tolerate dangling marks, 2020-09-01) adds a test
> that uses a BRE which breaks at least with OpenBSD's grep.
>
> switch to an ERE as it is done for similar checks and while at it, remove
> the now obsolete test_i18ngrep call.
Thanks, obviously correct.
I wonder if we can more automate detection of such a bug---it is
unfortunate that it has become very hard to avoid GNUisms as
everybody, even Windows folks, is more likely to be with GNU tools
than BSD tools X-<.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> t/t7508-status.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index 2b72451ba3..05c6c02435 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -882,7 +882,7 @@ test_expect_success 'status shows detached HEAD properly after checking out non-
> git clone upstream downstream &&
> git -C downstream checkout @{u} &&
> git -C downstream status >actual &&
> - test_i18ngrep "HEAD detached at [0-9a-f]\\+" actual
> + grep -E "HEAD detached at [0-9a-f]+" actual
> '
>
> test_expect_success 'setup status submodule summary' '
prev parent reply other threads:[~2021-08-02 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 21:53 [PATCH] t7508: avoid non POSIX BRE Carlo Marcelo Arenas Belón
2021-08-02 2:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv94oy3le.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).