From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Dixit\, Ashutosh" <ashutosh.dixit@intel.com>,
git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: Bug in 2.26: git-fetch fetching too many objects?
Date: Tue, 21 Apr 2020 13:06:34 -0700 [thread overview]
Message-ID: <xmqqtv1cmwmt.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200421193611.GA103469@google.com> (Jonathan Nieder's message of "Tue, 21 Apr 2020 12:36:11 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> In other words, if I understand correctly, it's describing an issue
> that also exists in protocol v0 for https. I would be *very*
> interested in any evidence one way or another about whether I am
> understanding correctly.
I am assuming that the issue experienced by these people after
flipping the default to v2 was *not* experienced by the same folks
back when they were not on v2. If not, I cannot explain why their
report say "it suddenly started doing this".
> ..., since we've been using protocol v2 as the
> default at $DAYJOB for quite a long time now.
Is it possible that folks getting hurt after 2.26 got released have
quite different use case / fetch pattern from what you see at
$DAYJOB, which are covered well in the current code? Keep using v2
at $DAYJOB may not help us diagnose the issue more than flipping the
default back (and at $DAYJOB the default is under your control ;-).
next prev parent reply other threads:[~2020-04-21 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 15:44 Bug in 2.26: git-fetch fetching too many objects? Dixit, Ashutosh
2020-04-20 17:03 ` Konstantin Ryabitsev
2020-04-21 5:18 ` Dixit, Ashutosh
2020-04-21 6:45 ` Jonathan Nieder
2020-04-21 19:16 ` Junio C Hamano
2020-04-21 19:36 ` Jonathan Nieder
2020-04-21 20:06 ` Junio C Hamano [this message]
2020-04-21 21:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtv1cmwmt.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=ashutosh.dixit@intel.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=konstantin@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).