From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"Dixit, Ashutosh" <ashutosh.dixit@intel.com>,
git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: Bug in 2.26: git-fetch fetching too many objects?
Date: Tue, 21 Apr 2020 17:11:33 -0400 [thread overview]
Message-ID: <20200421211133.GB3510074@coredump.intra.peff.net> (raw)
In-Reply-To: <20200421193611.GA103469@google.com>
On Tue, Apr 21, 2020 at 12:36:11PM -0700, Jonathan Nieder wrote:
> > This is at least the fourth time we hear that v2 may not be ready
> > for the real-world use. Perhaps we should revert the default flip
> > on the maintenance track while we hunt for bugs and improve the
> > protocol support?
>
> That feels to me like an overreaction, since these are all reports of
> the same issue that we have a fix to. Shouldn't we just flip the
> default for fetch.negotiationAlgorithm to skipping? If we revert to
> buy time, what would we do with that time?
Do we know that fetch.negotiationAlgorithm helps? I thought we didn't
yet know the actual cause of the bug. If that is the culprit, and people
would have seen this under v0 using stateless-http, why didn't we get
more reports of it then? Surely some people used http over git://?
I do agree that flipping the default away from v2 may be premature,
especially if we don't have a plan for moving forward. It sounds like
swapping out the negotiationAlgorithm would at least be likely to
generate more data, even if it is only a guess.
-Peff
prev parent reply other threads:[~2020-04-21 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 15:44 Bug in 2.26: git-fetch fetching too many objects? Dixit, Ashutosh
2020-04-20 17:03 ` Konstantin Ryabitsev
2020-04-21 5:18 ` Dixit, Ashutosh
2020-04-21 6:45 ` Jonathan Nieder
2020-04-21 19:16 ` Junio C Hamano
2020-04-21 19:36 ` Jonathan Nieder
2020-04-21 20:06 ` Junio C Hamano
2020-04-21 21:11 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421211133.GB3510074@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=ashutosh.dixit@intel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=konstantin@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).