git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: Bug in 2.26: git-fetch fetching too many objects?
Date: Mon, 20 Apr 2020 23:45:41 -0700	[thread overview]
Message-ID: <20200421064541.GG96152@google.com> (raw)
In-Reply-To: <878siqxiu0.wl-ashutosh.dixit@intel.com>

(+cc: Jonathan Tan, fetch negotiation expert)
Hi,

Dixit, Ashutosh wrote:

> I am seeing a strange behavior in git-fetch in 2.26. I frequently fetch
> from a couple of linux kernel remotes (so you will have an idea how big the
> repo is). I have a different system with 2.20 on which I never see a
> problem.
>
> So let us say I fetch with 2.20 and it fetches say 20,000 objects. However
> with 2.26 it starts fetching millions of objects, objects which are already
> present locally. I don't know yet if this happens each time or only once in
> a while, I have seen it happen twice, will keep an eye out for this.
>
> If you open a bug please let me know and I can update it with my
> findings. Unless it is a known issue, perhaps already fixed?

Does "git config --global fetch.negotiationAlgorithm skipping" help?
It might be time for us to make that the default.

I suspect this is related to the change that protocol v2 does to use
stateless-rpc even in stateful protocols.  If my suspicion is correct,
then the same behavior would show up with protocol v0 over http and
https as well.

Thanks and hope that helps,
Jonathan

  parent reply	other threads:[~2020-04-21  6:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 15:44 Bug in 2.26: git-fetch fetching too many objects? Dixit, Ashutosh
2020-04-20 17:03 ` Konstantin Ryabitsev
2020-04-21  5:18   ` Dixit, Ashutosh
2020-04-21  6:45 ` Jonathan Nieder [this message]
2020-04-21 19:16   ` Junio C Hamano
2020-04-21 19:36     ` Jonathan Nieder
2020-04-21 20:06       ` Junio C Hamano
2020-04-21 21:11       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421064541.GG96152@google.com \
    --to=jrnieder@gmail.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=konstantin@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).