From: Junio C Hamano <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: firstname.lastname@example.org Subject: Re: What's cooking in git.git (Aug 2019, #01; Thu, 1) Date: Fri, 02 Aug 2019 09:23:46 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20190801214247.GB30522@sigill.intra.peff.net> (Jeff King's message of "Thu, 1 Aug 2019 17:42:48 -0400") Jeff King <firstname.lastname@example.org> writes: > On Thu, Aug 01, 2019 at 01:05:12PM -0700, Junio C Hamano wrote: > >> [Graduated to "master"] >> [...] >> * jk/repack-silence-auto-bitmap-warning (2019-07-31) 3 commits >> (merged to 'next' on 2019-07-31 at 3aa218347c) >> + repack: simplify handling of auto-bitmaps and .keep files >> + repack: silence warnings when auto-enabled bitmaps cannot be built >> + t7700: clean up .keep file in bitmap-writing test >> >> Squelch unneeded and misleading warnings from "repack" when the >> command attempts to generate pack bitmaps without explicitly asked >> for by the user. > > After your "I need to digest this third one" comment in the thread, I > was surprised to see this merged so soon. :) I think it's fine, and I'd > be happy to see it in the upcoming release, but I just wanted to double > check that it was intentional. Yes, thanks for the simplification. It just took me a while to refresh my memory on the role '--honor-pack-keep' option and ignore_packed_keep_on_disk setting play in builtin/pack-objects.c, which is dense code. >> * jk/tree-walk-overflow (2019-07-31) 6 commits > ... >> Will merge to 'next'. > > Thanks. Stolee noted a minor typo fix in the commit message: > > https://email@example.com/ > > if it's not too late / too much trouble to fix. Thanks, both. I think I caught it before yesterday's integration run. >> * js/early-config-with-onbranch (2019-07-31) 1 commit >> (merged to 'next' on 2019-08-01 at 26b713c824) >> + config: work around bug with includeif:onbranch and early config >> >> The recently added [includeif "onbranch:branch"] feature does not >> work well with an early config mechanism, as it attempts to find >> out what branch we are on before we even haven't located the git >> repository. The inclusion during early config scan is ignored to >> work around this issue. >> >> Will merge to 'master'. > > I had some open comments here on how the "do we have a repo" check is > done, but I think what is committed here is functionally equivalent. I > can pursue the NULL the_repository cleanups separately. Yeah, I think Dscho's one is good enough for the upcoming release. Thanks.
next prev parent reply other threads:[~2019-08-02 16:23 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-01 20:05 Junio C Hamano 2019-08-01 21:42 ` Jeff King 2019-08-02 12:12 ` js/early-config-with-onbranch, was " Johannes Schindelin 2019-08-02 18:38 ` Jeff King 2019-08-02 16:23 ` Junio C Hamano [this message] 2019-08-02 12:06 ` js/visual-studio, " Johannes Schindelin 2019-08-02 16:42 ` Junio C Hamano 2019-08-03 20:22 ` Johannes Schindelin 2019-08-05 18:40 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: What'\''s cooking in git.git (Aug 2019, #01; Thu, 1)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).