Re: js/visual-studio, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi Junio,

On Fri, 2 Aug 2019, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >
> > On Thu, 1 Aug 2019, Junio C Hamano wrote:
> >
> >> * js/visual-studio (2019-07-29) 23 commits
> >>  - git: avoid calling aliased builtins via their dashed form
> >>  - bin-wrappers: append `.exe` to target paths if necessary
> >>  - .gitignore: ignore Visual Studio's temporary/generated files
> >>  - .gitignore: touch up the entries regarding Visual Studio
> >>  - vcxproj: also link-or-copy builtins
> >>  - msvc: add a Makefile target to pre-generate the Visual Studio solution
> >>  - contrib/buildsystems: add a backend for modern Visual Studio versions
> >>  - contrib/buildsystems: handle options starting with a slash
> >>  - contrib/buildsystems: also handle -lexpat
> >>  - contrib/buildsystems: handle libiconv, too
> >>  - contrib/buildsystems: handle the curl library option
> >>  - contrib/buildsystems: error out on unknown option
> >>  - contrib/buildsystems: optionally capture the dry-run in a file
> >>  - contrib/buildsystems: redirect errors of the dry run into a log file
> >>  - contrib/buildsystems: ignore gettext stuff
> >>  - contrib/buildsystems: handle quoted spaces in filenames
> >>  - contrib/buildsystems: fix misleading error message
> >>  - contrib/buildsystems: ignore irrelevant files in Generators/
> >>  - contrib/buildsystems: ignore invalidcontinue.obj
> >>  - Vcproj.pm: urlencode '<' and '>' when generating VC projects
> >>  - Vcproj.pm: do not configure VCWebServiceProxyGeneratorTool
> >>  - Vcproj.pm: list git.exe first to be startup project
> >>  - Vcproj.pm: auto-generate GUIDs
> >>
> >>  Support building Git with Visual Studio
> >>
> >>  The bits about .git/branches/* have been dropped from the series.
> >>  We may want to drop the support for it, but until that happens, the
> >>  tests should rely on the existence of the support to pass.
> >
> > As of v2, the tests rely on that existence again.
>
> Yup.  I think they are now in good shape to be among the first to
> graduate post release.  Building the warning facility necessary to
> start dropping the $GIT_DIR/branches/ support would be too late for
> this cycle, but now this topic is independent from that, so it may
> even be worth considering to have it in the upcoming release.

I see that you made up your mind and graduated the branch to `master`
already. Very happy about that, and of course I hope that this was
intentional ;-)

Just so you know what's building on top of this: I do have a PR lined up
that adds an MSVC build to the Azure Pipeline, but I have second
thoughts about it and think that it would probably be better to make
that a full Visual Studio build (the difference being: the MSVC build
requires both Visual Studio's Command Line Prompt *and* Git for Windows'
SDK to be installed, while the Visual Studio build would require only
Visual Studio for the build, and the Git for Windows SDK only for
generating the project files -- and maybe even a Linux agent could
generate those now).

In short: I hope to get the CI to the point of using the Visual Studio
support and testing it, over the next cycle.

Thanks,
Dscho