git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: js/early-config-with-onbranch, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)
Date: Fri, 2 Aug 2019 14:12:34 +0200 (CEST)
Message-ID: <nycvar.QRO.7.76.6.1908021410540.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190801214247.GB30522@sigill.intra.peff.net>

Hi Peff,

On Thu, 1 Aug 2019, Jeff King wrote:

> On Thu, Aug 01, 2019 at 01:05:12PM -0700, Junio C Hamano wrote:
>
> > * js/early-config-with-onbranch (2019-07-31) 1 commit
> >   (merged to 'next' on 2019-08-01 at 26b713c824)
> >  + config: work around bug with includeif:onbranch and early config
> >
> >  The recently added [includeif "onbranch:branch"] feature does not
> >  work well with an early config mechanism, as it attempts to find
> >  out what branch we are on before we even haven't located the git
> >  repository.  The inclusion during early config scan is ignored to
> >  work around this issue.
> >
> >  Will merge to 'master'.
>
> I had some open comments here on how the "do we have a repo" check is
> done, but I think what is committed here is functionally equivalent. I
> can pursue the NULL the_repository cleanups separately.

Right, I read that as "maybe later" comments, as that project is so
different from trying to fix the `onbranch` feature with regards to the
early config machinery.

Or did I misread and you want me to do anything about it before v2.23.0?

Ciao,
Dscho

  reply	other threads:[~2019-08-02 12:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 20:05 Junio C Hamano
2019-08-01 21:42 ` Jeff King
2019-08-02 12:12   ` Johannes Schindelin [this message]
2019-08-02 18:38     ` js/early-config-with-onbranch, was " Jeff King
2019-08-02 16:23   ` Junio C Hamano
2019-08-02 12:06 ` js/visual-studio, was " Johannes Schindelin
2019-08-02 16:42   ` Junio C Hamano
2019-08-03 20:22     ` Johannes Schindelin
2019-08-05 18:40       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1908021410540.46@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git