From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
git@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Steven Rostedt <rostedt@goodmis.org>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] git-send-email: Cc more people
Date: Thu, 19 Apr 2018 06:21:42 +0900 [thread overview]
Message-ID: <xmqqr2ncgqhl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <87tvs8e174.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 18 Apr 2018 21:58:39 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> But IMO this patch is really lacking a few things before being ready:
>
> 1. You have no tests for this. See t/t9001-send-email.sh for examples,
> ...
> 2. Just a few lines down from your quoted hunk we have this:
> ... code about $supress_cc{<token>} ...
> Your change should at least describe why those aren't being updated,
> but probably we should add some other command-line option for
> ignoring these wildcards, e.g. --[no-]wildcard-by-cc=reviewed
> --[no-]wildcard-by-cc=seen etc, and we can make --[no-]signed-off-by
> a historical alias for --[no-]wildcard-by-cc=signed-off.
> 3. Ditto all the documentation in "man git-send-email" about
> ...
Thanks, I agree that 2. (the lack of suppression) is a showstopper.
I'd further say that these new CC-sources should be disabled by
default and made opt-in to avoid surprising existing users.
One thing we also need to be very careful about is that some of the
fields may not even have an e-mail address. We can expect that
S-o-b and Cc would be of form "human readable name <email@addre.ss>"
by their nature, but it is perfectly fine to write only human
readable name without address on random lines like "suggeted-by" and
"helped-by". There needs a way for the end-user to avoid using data
found on such lines as if they are valid e-mail addresses.
next prev parent reply other threads:[~2018-04-18 21:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 14:05 [PATCH] git-send-email: Cc more people Matthew Wilcox
2018-04-18 14:33 ` Steven Rostedt
2018-04-18 17:25 ` Mathieu Desnoyers
2018-04-18 19:58 ` Ævar Arnfjörð Bjarmason
2018-04-18 21:21 ` Junio C Hamano [this message]
2018-04-19 12:10 ` Matthew Wilcox
2018-04-19 12:35 ` Mathieu Desnoyers
2018-04-20 0:03 ` Junio C Hamano
2018-04-20 15:27 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2ncgqhl.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=minchan@kernel.org \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).