From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: rostedt <rostedt@goodmis.org>
Cc: Matthew Wilcox <willy@infradead.org>,
git@vger.kernel.org, Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] git-send-email: Cc more people
Date: Wed, 18 Apr 2018 13:25:08 -0400 (EDT) [thread overview]
Message-ID: <1481207245.12764.1524072308610.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20180418103339.30bae9bc@gandalf.local.home>
----- On Apr 18, 2018, at 10:33 AM, rostedt rostedt@goodmis.org wrote:
> On Wed, 18 Apr 2018 07:05:03 -0700
> Matthew Wilcox <willy@infradead.org> wrote:
>
>> From: Matthew Wilcox <mawilcox@microsoft.com>
>>
>> Several of my colleagues (and myself) have expressed surprise and
>> annoyance that git-send-email doesn't automatically pick up people who
>> are listed in patches as Reported-by: or Reviewed-by: or ... many other
>> tags that would seem (to us) to indicate that person might be interested.
>> This patch to git-send-email tries to pick up all Foo-by: tags.
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Note, this is one of the reasons I still use quilt to send my email.
> I've modified my quilt scripts to do what Matthew does here below.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
I find it really surprising and unexpected that people listed as
"Reviewed-by" don't end up being CC'd.
Thanks,
Mathieu
>
> -- Steve
>
>
>>
>> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>>
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index 2fa7818ca..926815329 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -1665,7 +1665,7 @@ foreach my $t (@files) {
>> # Now parse the message body
>> while(<$fh>) {
>> $message .= $_;
>> - if (/^(Signed-off-by|Cc): (.*)/i) {
>> + if (/^([A-Z-a-z]*-by|Cc): (.*)/i) {
>> chomp;
>> my ($what, $c) = ($1, $2);
> > # strip garbage for the address we'll use:
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2018-04-18 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 14:05 [PATCH] git-send-email: Cc more people Matthew Wilcox
2018-04-18 14:33 ` Steven Rostedt
2018-04-18 17:25 ` Mathieu Desnoyers [this message]
2018-04-18 19:58 ` Ævar Arnfjörð Bjarmason
2018-04-18 21:21 ` Junio C Hamano
2018-04-19 12:10 ` Matthew Wilcox
2018-04-19 12:35 ` Mathieu Desnoyers
2018-04-20 0:03 ` Junio C Hamano
2018-04-20 15:27 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481207245.12764.1524072308610.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=git@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).