From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Matthew Wilcox" <willy@infradead.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git <git@vger.kernel.org>, rostedt <rostedt@goodmis.org>,
"Minchan Kim" <minchan@kernel.org>
Subject: Re: [PATCH] git-send-email: Cc more people
Date: Fri, 20 Apr 2018 11:27:39 -0400 (EDT) [thread overview]
Message-ID: <666133236.13971.1524238059705.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <xmqqtvs6d9r6.fsf@gitster-ct.c.googlers.com>
----- On Apr 19, 2018, at 8:03 PM, Junio C Hamano gitster@pobox.com wrote:
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
>
>>>> I'd further say that these new CC-sources should be disabled by
>>>> default and made opt-in to avoid surprising existing users.
>>>
>>> But I disagree with this. The current behaviour is surprising to
>>> existing users, to the point where people are writing their own scripts
>>> to replace git send-email (which seems crazy to me).
>>
>> We could perhaps go with a whitelist approach. The four
>> main match I would be tempted to add are: Acked-by, Reported-by,
>> Reviewed-by, and Tested-by.
>
> A tool that suddenly starts sending e-mails to more addresses
> without letting the end-users know when and why the change in
> behaviour happened is a source of irritated "somebody made a stupid
> change to git-send-email without telling us that caused unwanted
> e-mails sent to unexpected places and embarrassed me" bug reports.
> I do agree with a whitelist approach from that point of view, and in
> the initial rollout of the feature, that whitelist should be limited
> to what we already send out.
>
> The users who learn about this new feature can opt into whitelisting
> the common 4 above before we enable them by default. FWIW, I
> personally think these will be a sensible default (in addition to
> what we already Cc). I however prefer an approach to introduce
> these more gradually.
Sure, introducing changes like this needs to be done gradually.
Thanks!
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2018-04-20 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 14:05 [PATCH] git-send-email: Cc more people Matthew Wilcox
2018-04-18 14:33 ` Steven Rostedt
2018-04-18 17:25 ` Mathieu Desnoyers
2018-04-18 19:58 ` Ævar Arnfjörð Bjarmason
2018-04-18 21:21 ` Junio C Hamano
2018-04-19 12:10 ` Matthew Wilcox
2018-04-19 12:35 ` Mathieu Desnoyers
2018-04-20 0:03 ` Junio C Hamano
2018-04-20 15:27 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666133236.13971.1524238059705.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=minchan@kernel.org \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).