mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Johannes Schindelin <>
Cc: "Eric Sunshine" <>,
	"Johannes Schindelin via GitGitGadget" <>,
	"Git List" <>,
	"Ævar Arnfjörð Bjarmason" <>
Subject: Re: [PATCH 1/1] stash: document stash.useBuiltin
Date: Wed, 15 May 2019 17:52:57 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Johannes Schindelin's message of "Wed, 15 May 2019 10:26:36 +0200 (DST)")

Johannes Schindelin <> writes:

>> See a few nits below, none of which are necessarily worth a re-roll.
> Thanks!
> Junio, do you agree, do you want to fix it up on your side?

I think you'd see all of them in what I've pushed out.

>> > +one-off testing you should report the behavior difference as a bug in
>> s/testing/&,/
>> > +git (see for details).
>> s/^git/Git/

The last one might be a bit iffy, as we are talking about (a
possible bug in) a specific implementation of "git", as opposed to
Git as general concept, but I took it anyway.

Thanks, all.

  reply	other threads:[~2019-05-15  8:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  9:19 [PATCH 0/1] Document the stash.useBuiltin escape hatch Johannes Schindelin via GitGitGadget
2019-05-14  9:19 ` [PATCH 1/1] stash: document stash.useBuiltin Johannes Schindelin via GitGitGadget
2019-05-14  9:44   ` Ævar Arnfjörð Bjarmason
2019-05-15  1:15     ` Junio C Hamano
2019-05-14 19:57   ` Eric Sunshine
2019-05-15  8:26     ` Johannes Schindelin
2019-05-15  8:52       ` Junio C Hamano [this message]
2019-05-17 18:30         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).