git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
	"Git List" <git@vger.kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 1/1] stash: document stash.useBuiltin
Date: Wed, 15 May 2019 10:26:36 +0200 (DST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1905151025580.44@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <CAPig+cRoyOJrEuVY109NKafTCUc399p9tk64L9sZok=AOZ1MPg@mail.gmail.com>

Hi Eric,

On Tue, 14 May 2019, Eric Sunshine wrote:

> On Tue, May 14, 2019 at 5:19 AM Johannes Schindelin via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > The stash.useBuiltin variable introduced in 90a462725e ("stash:
> > optionally use the scripted version again", 2019-02-25) was turned on by
> > default, but had no documentation.
> >
> > Let's document it so that users who run into any stability issues with
> > the C rewrite know there's an escape hatch, and spell out that the
> > user should please report the bug when they have to turn off the
> > built-in stash.
>
> See a few nits below, none of which are necessarily worth a re-roll.

Thanks!

Junio, do you agree, do you want to fix it up on your side?

Ciao,
Dscho

>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > diff --git a/Documentation/config/stash.txt b/Documentation/config/stash.txt
> > @@ -1,3 +1,18 @@
> > +If you find some reason to set this option to `false` other than
>
> s/`false`/&,/
>
> > +one-off testing you should report the behavior difference as a bug in
>
> s/testing/&,/
>
> > +git (see https://git-scm.com/community for details).
>
> s/^git/Git/
>

  reply	other threads:[~2019-05-15  8:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  9:19 [PATCH 0/1] Document the stash.useBuiltin escape hatch Johannes Schindelin via GitGitGadget
2019-05-14  9:19 ` [PATCH 1/1] stash: document stash.useBuiltin Johannes Schindelin via GitGitGadget
2019-05-14  9:44   ` Ævar Arnfjörð Bjarmason
2019-05-15  1:15     ` Junio C Hamano
2019-05-14 19:57   ` Eric Sunshine
2019-05-15  8:26     ` Johannes Schindelin [this message]
2019-05-15  8:52       ` Junio C Hamano
2019-05-17 18:30         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1905151025580.44@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).