mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <>
To: Johannes Schindelin via GitGitGadget <>
Cc: "Git List" <>,
	"Ævar Arnfjörð Bjarmason" <>,
	"Junio C Hamano" <>,
	"Johannes Schindelin" <>
Subject: Re: [PATCH 1/1] stash: document stash.useBuiltin
Date: Tue, 14 May 2019 15:57:10 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, May 14, 2019 at 5:19 AM Johannes Schindelin via GitGitGadget
<> wrote:
> The stash.useBuiltin variable introduced in 90a462725e ("stash:
> optionally use the scripted version again", 2019-02-25) was turned on by
> default, but had no documentation.
> Let's document it so that users who run into any stability issues with
> the C rewrite know there's an escape hatch, and spell out that the
> user should please report the bug when they have to turn off the
> built-in stash.

See a few nits below, none of which are necessarily worth a re-roll.

> Signed-off-by: Johannes Schindelin <>
> ---
> diff --git a/Documentation/config/stash.txt b/Documentation/config/stash.txt
> @@ -1,3 +1,18 @@
> +If you find some reason to set this option to `false` other than


> +one-off testing you should report the behavior difference as a bug in


> +git (see for details).


  parent reply	other threads:[~2019-05-14 19:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  9:19 [PATCH 0/1] Document the stash.useBuiltin escape hatch Johannes Schindelin via GitGitGadget
2019-05-14  9:19 ` [PATCH 1/1] stash: document stash.useBuiltin Johannes Schindelin via GitGitGadget
2019-05-14  9:44   ` Ævar Arnfjörð Bjarmason
2019-05-15  1:15     ` Junio C Hamano
2019-05-14 19:57   ` Eric Sunshine [this message]
2019-05-15  8:26     ` Johannes Schindelin
2019-05-15  8:52       ` Junio C Hamano
2019-05-17 18:30         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).