git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
* What's cooking in git.git (Feb 2020, #03; Wed, 12)
@ 2020-02-12 21:58 Junio C Hamano
  2020-02-13 12:26 ` bw/remote-rename-update-config, was " Johannes Schindelin
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Junio C Hamano @ 2020-02-12 21:58 UTC (permalink / raw)
  To: git

Here are the topics that have been cooking.  Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.  The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.

The fourth batch of topics are now in 'master'.

You can find the changes described here in the integration branches
of the repositories listed at

    http://git-blame.blogspot.com/p/git-public-repositories.html

--------------------------------------------------
[Graduated to "master"]

* dt/submodule-rm-with-stale-cache (2020-01-28) 1 commit
  (merged to 'next' on 2020-02-05 at 701ef6c41b)
 + git rm submodule: succeed if .gitmodules index stat info is zero

 Running "git rm" on a submodule failed unnecessarily when
 .gitmodules is only cache-dirty, which has been corrected.


* es/submodule-fetch-message-fix (2020-02-07) 1 commit
  (merged to 'next' on 2020-02-11 at b8af267e1b)
 + submodule: add newline on invalid submodule error

 Error message fix.


* hw/doc-git-dir (2020-01-30) 1 commit
  (merged to 'next' on 2020-02-05 at 839ae05c00)
 + git: update documentation for --git-dir

 One effect of specifying where the GIT_DIR is (either with the
 environment variable, or with the "git --git-dir=<where> cmd"
 option) is to disable the repository discovery.  This has been
 placed a bit more stress in the documentation, as new users often
 get confused.


* jb/multi-pack-index-docfix (2020-02-10) 1 commit
  (merged to 'next' on 2020-02-11 at 79af4f7bda)
 + pack-format: correct multi-pack-index description

 Doc fix.


* jb/parse-options-message-fix (2020-02-05) 1 commit
  (merged to 'next' on 2020-02-11 at 58058cc68c)
 + parse-options: lose an unnecessary space in an error message

 Error message fix.


* jc/skip-prefix (2020-01-31) 1 commit
  (merged to 'next' on 2020-02-05 at f6893a42d0)
 + C: use skip_prefix() to avoid hardcoded string length

 Code simplification.


* jk/clang-sanitizer-fixes (2020-01-28) 5 commits
  (merged to 'next' on 2020-02-05 at 8ef84c2d96)
 + obstack: avoid computing offsets from NULL pointer
 + xdiff: avoid computing non-zero offset from NULL pointer
 + avoid computing zero offsets from NULL pointer
 + merge-recursive: use subtraction to flip stage
 + merge-recursive: silence -Wxor-used-as-pow warning

 C pedantry ;-) fix.


* jk/escaped-wildcard-dwim (2020-01-27) 1 commit
  (merged to 'next' on 2020-02-05 at ebee5e92a7)
 + verify_filename(): handle backslashes in "wildcards are pathspecs" rule

 Disambiguation logic to tell revisions and pathspec apart has been
 tweaked so that backslash-escaped glob special characters do not
 count in the "wildcards are pathspec" rule.


* jk/push-default-doc (2020-01-29) 1 commit
  (merged to 'next' on 2020-02-05 at 33167357a1)
 + doc: drop "explicitly given" from push.default description

 Doc update.


* jn/pretend-object-doc (2020-01-06) 1 commit
  (merged to 'next' on 2020-02-05 at 1d52a5c72d)
 + sha1-file: document how to use pretend_object_file

 Warn programmers about pretend_object_file() that allows the code
 to tentatively use in-core objects.


* js/ci-squelch-doc-warning (2020-02-10) 1 commit
  (merged to 'next' on 2020-02-11 at 4fec29107e)
 + ci: ignore rubygems warning in the "Documentation" job

 Squelch unhelpful warning message during documentation build.


* js/convert-typofix (2020-02-11) 1 commit
  (merged to 'next' on 2020-02-11 at 32ccd29dc5)
 + convert: fix typo

 Typofix.


* jt/t5616-robustify (2020-01-27) 1 commit
  (merged to 'next' on 2020-02-05 at cdb02e8849)
 + t5616: make robust to delta base change

 Futureproofing a test not to depend on the current implementation
 detail.


* km/submodule-doc-use-sm-path (2020-01-31) 1 commit
  (merged to 'next' on 2020-02-05 at a73aa350b5)
 + submodule foreach: replace $path with $sm_path in example

 Docfix.


* ma/diff-doc-clarify-regexp-example (2020-02-09) 1 commit
  (merged to 'next' on 2020-02-11 at 202d447e78)
 + diff-options.txt: avoid "regex" overload in example

 Doc clarification.


* ma/filter-branch-doc-caret (2020-02-04) 1 commit
  (merged to 'next' on 2020-02-05 at 4d5dbd1dba)
 + git-filter-branch.txt: wrap "maths" notation in backticks

 Doc mark-up updates.


* ms/doc-bundle-format (2020-02-07) 1 commit
  (merged to 'next' on 2020-02-11 at ca03a36134)
 + doc: describe Git bundle format

 Technical details of the bundle format has been documented.
 I think this is in a good enough shape.


* pb/do-not-recurse-grep-no-index (2020-01-30) 1 commit
  (merged to 'next' on 2020-02-05 at 227bbe1e05)
 + grep: ignore --recurse-submodules if --no-index is given

 "git grep --no-index" should not get affected by the contents of
 the .gitmodules file but when "--recurse-submodules" is given or
 the "submodule.recurse" variable is set, it did.  Now these
 settings are ignored in the "--no-index" mode.

--------------------------------------------------
[New Topics]

* ds/sparse-add (2020-02-11) 4 commits
 - sparse-checkout: work with Windows paths
 - sparse-checkout: create 'add' subcommand
 - sparse-checkout: extract pattern update from 'set' subcommand
 - sparse-checkout: extract add_patterns_from_input()
 (this branch uses ds/sparse-checkout-harden.)

 "git sparse-checkout" learned a new "add" subcommand.

 Will merge to 'next'.


* jk/mailinfo-cleanup (2020-02-11) 4 commits
  (merged to 'next' on 2020-02-11 at ab9890fbcb)
 + mailinfo: factor out some repeated header handling
 + mailinfo: be more liberal with header whitespace
 + mailinfo: simplify parsing of header values
 + mailinfo: treat header values as C strings
 (this branch uses rs/strbuf-insertstr.)

 Code clean-up.

 Will merge to 'master'.


* js/test-write-junit-xml-fix (2020-02-12) 1 commit
 - tests: fix --write-junit-xml with subshells

 Testfix.

 Will merge to 'next'.

--------------------------------------------------
[Stalled]

* pw/advise-rebase-skip (2019-12-06) 9 commits
 - rebase -i: leave CHERRY_PICK_HEAD when there are conflicts
 - rebase: fix advice when a fixup creates an empty commit
 - commit: give correct advice for empty commit during a rebase
 - commit: encapsulate determine_whence() for sequencer
 - commit: use enum value for multiple cherry-picks
 - sequencer: write CHERRY_PICK_HEAD for reword and edit
 - cherry-pick: check commit error messages
 - cherry-pick: add test for `--skip` advice in `git commit`
 - t3404: use test_cmp_rev

 The mechanism to prevent "git commit" from making an empty commit
 or amending during an interrupted cherry-pick was broken during the
 rewrite of "git rebase" in C, which has been corrected.

 What's the status of this one?
 The tip two are still RFC.


* vn/reset-deleted-ita (2019-07-26) 1 commit
 - reset: unstage empty deleted ita files

 "git reset HEAD [<pathspec>]" did not reset an empty file that was
 added with the intent-to-add bit.

 Expecting a reroll.


* mk/use-size-t-in-zlib (2018-10-15) 1 commit
 - zlib.c: use size_t for size

 The wrapper to call into zlib followed our long tradition to use
 "unsigned long" for sizes of regions in memory, which have been
 updated to use "size_t".

--------------------------------------------------
[Cooking]

* at/rebase-fork-point-regression-fix (2020-02-11) 1 commit
 - rebase: --fork-point regression fix

 The "--fork-point" mode of "git rebase" regressed when the command
 was rewritten in C back in 2.20 era, which has been corrected.

 Was waiting for discussion to settle.
 cf. <CAPig+cQ-3Ds41hr91fRo_GvuFMTP7zNVJtaSqi-Yccq4Pk-8Qg@mail.gmail.com>
 cf. <xmqq36dtwcvw.fsf@gitster-ct.c.googlers.com>


* hn/reftable (2020-02-10) 5 commits
 - Reftable support for git-core
 - Add reftable library
 - refs: document how ref_iterator_advance_fn should handle symrefs
 - create .git/refs in files-backend.c
 - refs.h: clarify reflog iteration order

 A new refs backend "reftable" to replace the traditional
 combination of packed-refs files and one-file-per-ref loose refs
 has been implemented and integrated for improved performance and
 atomicity.

 At v5.


* es/bugreport (2020-02-12) 16 commits
 - SQUASH??? t0091 style and i18n fixes
 - bugreport: summarize contents of alternates file
 - bugreport: list contents of $OBJDIR/info
 - bugreport: add packed object summary
 - bugreport: count loose objects
 - bugreport: collect list of populated hooks
 - bugreport: add config values from safelist
 - bugreport: generate config safelist based on docs
 - bugreport: include user interactive shell
 - bugreport: add git-remote-https version
 - bugreport: add compiler info
 - bugreport: add uname info
 - bugreport: gather git version and build info
 - bugreport: add tool to generate debugging info
 - help: add shell-path to --build-options
 - help: move list_config_help to builtin/help
 (this branch uses mr/show-config-scope; is tangled with bw/remote-rename-update-config.)

 The "bugreport" tool.

 at v6.  Breaks gettext-poison builds


* gs/commit-graph-path-filter (2020-02-12) 12 commits
 - (bytesex breakage band-aid)
 - commit-graph: add GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS test flag
 - revision.c: use Bloom filters to speed up path based revision walks
 - commit-graph: add --changed-paths option to write subcommand
 - commit-graph: reuse existing Bloom filters during write.
 - commit-graph: write Bloom filters to commit graph file
 - commit-graph: examine commits by generation number
 - commit-graph: examine changed-path objects in pack order
 - commit-graph: compute Bloom filters for changed paths
 - diff: halt tree-diff early after max_changes
 - bloom: core Bloom filter implementation for changed paths
 - commit-graph: use MAX_NUM_CHUNKS

 Introduce an extension to the commit-graph to make it efficient to
 check for the paths that were modified at each commit using Bloom
 filters.

 Will be rerolled with bytesex fixes squashed in.
 Breakage due to byte-order dependency reported.


* bc/hash-independent-tests-part-8 (2020-02-07) 21 commits
  (merged to 'next' on 2020-02-11 at 127748e61a)
 + t6024: update for SHA-256
 + t6006: make hash size independent
 + t6000: abstract away SHA-1-specific constants
 + t5703: make test work with SHA-256
 + t5607: make hash size independent
 + t5318: update for SHA-256
 + t5515: make test hash independent
 + t5321: make test hash independent
 + t5313: make test hash independent
 + t5309: make test hash independent
 + t5302: make hash size independent
 + t4060: make test work with SHA-256
 + t4211: add test cases for SHA-256
 + t4211: move SHA-1-specific test cases into a directory
 + t4013: make test hash independent
 + t3311: make test work with SHA-256
 + t3310: make test work with SHA-256
 + t3309: make test work with SHA-256
 + t3308: make test work with SHA-256
 + t3206: make hash size independent
 + t/lib-pack: support SHA-256

 Preparation for SHA-256 migration continues.

 Will merge to 'master'.


* mr/bisect-in-c-1 (2020-02-10) 13 commits
 - bisect: libify `bisect_next_all`
 - bisect: libify `handle_bad_merge_base` and its dependents
 - bisect: libify `check_good_are_ancestors_of_bad` and its dependents
 - bisect: libify `check_merge_bases` and its dependents
 - bisect: libify `bisect_checkout`
 - bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependents
 - bisect--helper: return error codes from `cmd_bisect__helper()`
 - bisect: add enum to represent bisect returning codes
 - bisect--helper: introduce new `decide_next()` function
 - run-command: make `exists_in_PATH()` non-static
 - bisect: use the standard 'if (!var)' way to check for 0
 - bisect--helper: change `retval` to `res`
 - bisect--helper: convert `vocab_*` char pointers to char arrays

 Underlying machinery of "git bisect--helper" is being refactored
 into pieces that are more easily reused.


* rs/parse-options-concat-dup (2020-02-10) 4 commits
  (merged to 'next' on 2020-02-11 at a1685687ab)
 + parse-options: simplify parse_options_dup()
 + parse-options: const parse_options_concat() parameters
 + parse-options: factor out parse_options_count()
 + parse-options: use COPY_ARRAY in parse_options_concat()

 Code clean-up.

 Will merge to 'master'.


* rs/strbuf-insertstr (2020-02-10) 2 commits
  (merged to 'next' on 2020-02-11 at 5c89aa002f)
 + mailinfo: don't insert header prefix for handle_content_type()
 + strbuf: add and use strbuf_insertstr()
 (this branch is used by jk/mailinfo-cleanup.)

 Code clean-up.

 Will merge to 'master'.


* bw/remote-rename-update-config (2020-02-10) 6 commits
 - remote rename/remove: gently handle remote.pushDefault config
 - config: provide access to the current line number
 - remote rename/remove: handle branch.<name>.pushRemote config values
 - remote: clean-up config callback
 - remote: clean-up by returning early to avoid one indentation
 - pull --rebase/remote rename: document and honor single-letter abbreviations rebase types
 (this branch uses mr/show-config-scope; is tangled with es/bugreport.)

 "git remote rename X Y" needs to adjust configuration variables
 (e.g. branch.<name>.remote) whose value used to be X to Y.
 branch.<name>.pushRemote is now also updated.

 Will merge to 'next'?


* es/bright-colors (2020-02-11) 3 commits
 - color.c: alias RGB colors 8-15 to aixterm colors
 - color.c: support bright aixterm colors
 - color.c: refactor color_output arguments

 The basic 7 colors learned the brighter counterparts
 (e.g. "brightred").

 Will merge to 'next'.


* pk/status-of-uncloned-submodule (2020-02-04) 3 commits
  (merged to 'next' on 2020-02-07 at f6349f5f5f)
 + t7400: testcase for submodule status on unregistered inner git repos
 + submodule: fix status of initialized but not cloned submodules
 + t7400: add a testcase for submodule status on empty dirs

 The way "git submodule status" reports an initialized but not yet
 populated submodule has not been reimplemented correctly when a
 part of the "git submodule" command was rewritten in C, which has
 been corrected.

 Will merge to 'master'.


* ag/rebase-avoid-unneeded-checkout (2020-01-24) 1 commit
  (merged to 'next' on 2020-02-07 at b08da07534)
 + rebase -i: stop checking out the tip of the branch to rebase

 "git rebase -i" (and friends) used to unnecessarily check out the
 tip of the branch to be rebased, which has been corrected.

 Will merge to 'master'.


* ds/sparse-checkout-harden (2020-01-31) 15 commits
  (merged to 'next' on 2020-02-07 at 56c09b944f)
 + sparse-checkout: fix cone mode behavior mismatch
 + sparse-checkout: improve docs around 'set' in cone mode
 + sparse-checkout: escape all glob characters on write
 + sparse-checkout: use C-style quotes in 'list' subcommand
 + sparse-checkout: unquote C-style strings over --stdin
 + sparse-checkout: write escaped patterns in cone mode
 + sparse-checkout: properly match escaped characters
 + sparse-checkout: warn on globs in cone patterns
 + sparse-checkout: detect short patterns
 + sparse-checkout: cone mode does not recognize "**"
 + sparse-checkout: fix documentation typo for core.sparseCheckoutCone
 + clone: fix --sparse option with URLs
 + sparse-checkout: create leading directories
 + t1091: improve here-docs
 + t1091: use check_files to reduce boilerplate
 (this branch is used by ds/sparse-add.)

 Some rough edges in the sparse-checkout feature, especially around
 the cone mode, have been cleaned up.

 Will merge to 'master'.


* es/doc-mentoring (2020-01-24) 1 commit
  (merged to 'next' on 2020-02-05 at 3b05aabbcd)
 + MyFirstContribution: add avenues for getting help

 Doc for new contributors.

 Waiting for the discussion to settle.
 cf. <20200206010704.GN10482@szeder.dev>


* mr/show-config-scope (2020-02-10) 10 commits
  (merged to 'next' on 2020-02-11 at 904bca086e)
 + config: add '--show-scope' to print the scope of a config value
 + submodule-config: add subomdule config scope
 + config: teach git_config_source to remember its scope
 + config: preserve scope in do_git_config_sequence
 + config: clarify meaning of command line scoping
 + config: split repo scope to local and worktree
 + config: make scope_name non-static and rename it
 + t1300: create custom config file without special characters
 + t1300: fix over-indented HERE-DOCs
 + config: fix typo in variable name
 (this branch is used by bw/remote-rename-update-config and es/bugreport.)

 "git config" learned to show in which "scope", in addition to in
 which file, each config setting comes from.

 Will merge to 'master'.


* bk/p4-pre-edit-changelist (2020-02-11) 7 commits
 - git-p4: add RCS keyword status message
 - git-p4: add p4 submit hooks
 - git-p4: restructure code in submit
 - git-p4: add --no-verify option
 - git-p4: add p4-pre-submit exit text
 - git-p4: create new function run_git_hook
 - git-p4: rewrite prompt to be Windows compatible

 "git p4" learned four new hooks and also "--no-verify" option to
 bypass them (and the existing "p4-pre-submit" hook).


* en/fill-directory-exponential (2020-01-31) 6 commits
 - t7063: blindly accept diffs
 - dir: replace exponential algorithm with a linear one
 - dir: refactor treat_directory to clarify control flow
 - dir: fix confusion based on variable tense
 - dir: fix broken comment
 - dir: consolidate treat_path() and treat_one_path()

 The directory traversal code had redundant recursive calls which
 made its performance characteristics exponential wrt the depth of
 the tree, which was corrected.

 Still RFC?
 cf. <pull.700.v2.git.git.1580495486.gitgitgadget@gmail.com>
 cf. <CABPp-BF0SO92wxY-dM14Vxv6BGA5=T=CicdwbiaZ7c9w6-j2jQ@mail.gmail.com>


* jh/notes-fanout-fix (2020-02-04) 2 commits
  (merged to 'next' on 2020-02-07 at a4ec94aee0)
 + notes.c: fix off-by-one error when decreasing notes fanout
 + t3305: check notes fanout more carefully and robustly

 The code to automatically shrink the fan-out in the notes tree had
 an off-by-one bug, which has been killed.

 Will merge to 'master'.


* jk/alloc-cleanups (2020-02-04) 4 commits
  (merged to 'next' on 2020-02-07 at f259621312)
 + tree-walk.c: break circular dependency with unpack-trees
 + traverse_trees(): use stack array for name entries
 + walker_fetch(): avoid raw array length computation
 + normalize_path_copy(): document "dst" size expectations

 Misc code clean-ups.

 Will merge to 'master'.


* jk/diff-honor-wserrhighlight-in-plumbing (2020-01-31) 1 commit
  (merged to 'next' on 2020-02-07 at acb077fdcb)
 + diff: move diff.wsErrorHighlight to "basic" config

 The diff-* plumbing family of subcommands now pay attention to the
 diff.wsErrorHighlight configuration, which has been ignored before;
 this allows "git add -p" to also show the whitespace problems to
 the end user.

 Will merge to 'master'.


* jk/get-oid-error-message-i18n (2020-01-30) 3 commits
  (merged to 'next' on 2020-02-07 at 6bfe9235e5)
 + sha1-name: mark get_oid() error messages for translation
 + t1506: drop space after redirection operator
 + t1400: avoid "test" string comparisons

 A low-level API function get_oid(), that accepts various ways to
 name an object, used to issue end-user facing error messages
 without l10n, which has been updated to be translatable.

 Will merge to 'master'.


* jk/index-pack-dupfix (2020-02-04) 1 commit
  (merged to 'next' on 2020-02-07 at e6d79d432b)
 + index-pack: downgrade twice-resolved REF_DELTA to die()

 The index-pack code now diagnoses a bad input packstream that
 records the same object twice when it is used as delta base; the
 code used to declare a software bug when encountering such an
 input, but it is an input error.

 Will merge to 'master'.


* jt/connectivity-check-optim-in-partial-clone (2020-01-30) 2 commits
  (merged to 'next' on 2020-02-07 at ca5102fa58)
 + fetch: forgo full connectivity check if --filter
 + connected: verify promisor-ness of partial clone

 Unneeded connectivity check is now disabled in a partial clone when
 fetching into it.

 Will merge to 'master'.


* ld/p4-cleanup-processes (2020-01-30) 7 commits
  (merged to 'next' on 2020-02-07 at e8c573f01c)
 + git-p4: avoid leak of file handle when cloning
 + git-p4: check for access to remote host earlier
 + git-p4: cleanup better on error exit
 + git-p4: create helper function importRevisions()
 + git-p4: disable some pylint warnings, to get pylint output to something manageable
 + git-p4: add P4CommandException to report errors talking to Perforce
 + git-p4: make closeStreams() idempotent

 p4 updates.

 Will merge to 'master'.


* mt/use-passed-repo-more-in-funcs (2020-01-31) 7 commits
  (merged to 'next' on 2020-02-07 at 536709ab4b)
 + sha1-file: allow check_object_signature() to handle any repo
 + sha1-file: pass git_hash_algo to hash_object_file()
 + sha1-file: pass git_hash_algo to write_object_file_prepare()
 + streaming: allow open_istream() to handle any repo
 + pack-check: use given repo's hash_algo at verify_packfile()
 + cache-tree: use given repo's hash_algo at verify_one()
 + diff: make diff_populate_filespec() honor its repo argument

 Some codepaths were given a repository instance as a parameter to
 work in the repository, but passed the_repository instance to its
 callees, which has been cleaned up (somewhat).

 Will merge to 'master'.


* rs/name-rev-memsave (2020-02-05) 11 commits
  (merged to 'next' on 2020-02-11 at 17616cb9b1)
 + name-rev: sort tip names before applying
 + name-rev: release unused name strings
 + name-rev: generate name strings only if they are better
 + name-rev: pre-size buffer in get_parent_name()
 + name-rev: factor out get_parent_name()
 + name-rev: put struct rev_name into commit slab
 + name-rev: don't _peek() in create_or_update_name()
 + name-rev: don't leak path copy in name_ref()
 + name-rev: respect const qualifier
 + name-rev: remove unused typedef
 + name-rev: rewrite create_or_update_name()

 Memory footprint and performance of "git name-rev" has been
 improved.

 Will merge to 'master'.


* tb/commit-graph-object-dir (2020-02-04) 5 commits
  (merged to 'next' on 2020-02-07 at 5c85173df4)
 + commit-graph.h: use odb in 'load_commit_graph_one_fd_st'
 + commit-graph.c: remove path normalization, comparison
 + commit-graph.h: store object directory in 'struct commit_graph'
 + commit-graph.h: store an odb in 'struct write_commit_graph_context'
 + t5318: don't pass non-object directory to '--object-dir'
 (this branch is used by tb/commit-graph-split-merge.)

 The code to compute the commit-graph has been taught to use a more
 robust way to tell if two object directories refer to the same
 thing.

 Will merge to 'master'.


* tb/commit-graph-split-merge (2020-02-12) 3 commits
 - builtin/commit-graph.c: support '--input=none'
 - builtin/commit-graph.c: introduce '--input=<source>'
 - builtin/commit-graph.c: support '--split[=<strategy>]'
 (this branch uses tb/commit-graph-object-dir.)

 The code to write out the commit-graph has been taught a few
 options to control if the resulting graph chains should be merged
 or a single new incremental graph is created.

 Waiting for the discussion to settle.
 cf. <20200212205028.GE4364@syl.local>


* ag/edit-todo-drop-check (2020-01-28) 2 commits
  (merged to 'next' on 2020-02-07 at 687c82cd3a)
 + rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
 + sequencer: move check_todo_list_from_file() to rebase-interactive.c
 (this branch uses js/rebase-i-with-colliding-hash.)

 Allow the rebase.missingCommitsCheck configuration to kick in when
 "rebase --edit-todo" and "rebase --continue" restarts the procedure.

 Will merge to 'master'.


* kw/fsmonitor-watchman-racefix (2020-01-23) 4 commits
  (merged to 'next' on 2020-02-07 at 3c42195a34)
 + fsmonitor: update documentation for hook version and watchman hooks
 + fsmonitor: add fsmonitor hook scripts for version 2
 + fsmonitor: handle version 2 of the hooks that will use opaque token
 + fsmonitor: change last update timestamp on the index_state to opaque token

 A new version of fsmonitor-watchman hook has been introduced, to
 avoid races.

 Will merge to 'master'.


* hw/advice-add-nothing (2020-02-06) 2 commits
  (merged to 'next' on 2020-02-07 at 3c2a5c1868)
 + add: change advice config variables used by the add API
  (merged to 'next' on 2020-01-22 at 3fe4494fa6)
 + add: use advise function to display hints

 Two help messages given when "git add" notices the user gave it
 nothing to add have been updated to use advise() API.

 Will merge to 'master'.


* am/pathspec-f-f-more (2020-02-10) 8 commits
 - stash push: support the --pathspec-from-file option
 - stash: eliminate crude option parsing
 - doc: stash: synchronize <pathspec> description
 - doc: stash: document more options
 - doc: stash: split options from description (2)
 - doc: stash: split options from description (1)
 - rm: support the --pathspec-from-file option
 - doc: rm: synchronize <pathspec> description

 "git rm" and "git stash" learns the new "--pathspec-from-file"
 option.


* js/rebase-i-with-colliding-hash (2020-01-23) 3 commits
  (merged to 'next' on 2020-02-07 at 670ba07c4d)
 + rebase -i: also avoid SHA-1 collisions with missingCommitsCheck
 + rebase -i: re-fix short SHA-1 collision
 + parse_insn_line(): improve error message when parsing failed
 (this branch is used by ag/edit-todo-drop-check.)

 "git rebase -i" identifies existing commits in its todo file with
 their abbreviated object name, which could become ambigous as it
 goes to create new commits, and has a mechanism to avoid ambiguity
 in the main part of its execution.  A few other cases however were
 not covered by the protection against ambiguity, which has been
 corrected.

 Will merge to 'master'.


* mt/threaded-grep-in-object-store (2020-01-17) 12 commits
  (merged to 'next' on 2020-02-07 at e86bab09e1)
 + grep: use no. of cores as the default no. of threads
 + grep: move driver pre-load out of critical section
 + grep: re-enable threads in non-worktree case
 + grep: protect packed_git [re-]initialization
 + grep: allow submodule functions to run in parallel
 + submodule-config: add skip_if_read option to repo_read_gitmodules()
 + grep: replace grep_read_mutex by internal obj read lock
 + object-store: allow threaded access to object reading
 + replace-object: make replace operations thread-safe
 + grep: fix racy calls in grep_objects()
 + grep: fix race conditions at grep_submodule()
 + grep: fix race conditions on userdiff calls

 Traditionally, we avoided threaded grep while searching in objects
 (as opposed to files in the working tree) as accesses to the object
 layer is not thread-safe.  This limitation is getting lifted.

 Will merge to 'master'.


* dl/merge-autostash (2020-01-13) 17 commits
 - pull: pass --autostash to merge
 - t5520: make test_pull_autostash() accept expect_parent_num
 - merge: teach --autostash option
 - sequencer: unlink autostash in apply_autostash()
 - sequencer: extract perform_autostash() from rebase
 - rebase: generify create_autostash()
 - rebase: extract create_autostash()
 - reset: extract reset_head() from rebase
 - rebase: generify reset_head()
 - rebase: use apply_autostash() from sequencer.c
 - sequencer: make apply_rebase() accept a path
 - rebase: use read_oneliner()
 - sequencer: make read_oneliner() extern
 - sequencer: configurably warn on non-existent files
 - sequencer: use file strbuf for read_oneliner()
 - t7600: use test_write_lines()
 - Makefile: alphabetically sort += lists

 "git merge" learns the "--autostash" option.

 Expecting a reroll.
 cf. <20200123042906.GA29009@generichostname>


* dl/test-must-fail-fixes-2 (2020-01-27) 16 commits
  (merged to 'next' on 2020-02-07 at 535e019692)
 + t4124: only mark git command with test_must_fail
 + t3507: use test_path_is_missing()
 + t3507: fix indentation
 + t3504: do check for conflict marker after failed cherry-pick
 + t3419: stop losing return code of git command
 + t3415: increase granularity of test_auto_{fixup,squash}()
 + t3415: stop losing return codes of git commands
 + t3310: extract common notes_merge_files_gone()
 + t3030: use test_path_is_missing()
 + t2018: replace "sha" with "oid"
 + t2018: don't lose return code of git commands
 + t2018: teach do_checkout() to accept `!` arg
 + t2018: be more discerning when checking for expected exit codes
 + t2018: improve style of if-statement
 + t2018: add space between function name and ()
 + t2018: remove trailing space from test description

 Test updates.

 Will merge to 'master'.


* jn/promote-proto2-to-default (2020-01-15) 5 commits
  (merged to 'next' on 2020-02-07 at 5597fd726b)
 + fetch: default to protocol version 2
 + protocol test: let protocol.version override GIT_TEST_PROTOCOL_VERSION
 + test: request GIT_TEST_PROTOCOL_VERSION=0 when appropriate
 + config doc: protocol.version is not experimental
 + fetch test: use more robust test for filtered objects

 The transport protocol version 2 becomes the default one.

 Will merge to 'master'.


* yz/p4-py3 (2020-01-15) 14 commits
 . ci: also run linux-gcc pipeline with python3.5 environment
 - git-p4: use python3's input() everywhere
 - git-p4: simplify regex pattern generation for parsing diff-tree
 - git-p4: use dict.items() iteration for python3 compatibility
 - git-p4: use functools.reduce instead of reduce
 - git-p4: fix freezing while waiting for fast-import progress
 - git-p4: use marshal format version 2 when sending to p4
 - git-p4: open .gitp4-usercache.txt in text mode
 - git-p4: convert path to unicode before processing them
 - git-p4: encode/decode communication with git for python3
 - git-p4: encode/decode communication with p4 for python3
 - git-p4: remove string type aliasing
 - git-p4: change the expansion test from basestring to list
 - git-p4: make python2.7 the oldest supported version

 Update "git p4" to work with Python 3.

 Hold.
 The last step is too wasteful to run full tests twice.
 cf. <20200122235333.GA6837@szeder.dev>
 cf. <20200123175645.GF6837@szeder.dev>


* en/rebase-backend (2020-01-17) 19 commits
 - rebase: change the default backend from "am" to "merge"
 - rebase: make the backend configurable via config setting
 - rebase tests: repeat some tests using the merge backend instead of am
 - rebase tests: mark tests specific to the am-backend with --am
 - rebase: drop '-i' from the reflog for interactive-based rebases
 - git-prompt: change the prompt for interactive-based rebases
 - rebase: add an --am option
 - rebase: move incompatibility checks between backend options a bit earlier
 - git-rebase.txt: add more details about behavioral differences of backends
 - rebase: allow more types of rebases to fast-forward
 - t3432: make these tests work with either am or merge backends
 - rebase: fix handling of restrict_revision
 - rebase: make sure to pass along the quiet flag to the sequencer
 - rebase, sequencer: remove the broken GIT_QUIET handling
 - t3406: simplify an already simple test
 - rebase (interactive-backend): fix handling of commits that become empty
 - rebase (interactive-backend): make --keep-empty the default
 - t3404: directly test the behavior of interest
 - git-rebase.txt: update description of --allow-empty-message

 "git rebase" has learned to use the sequencer backend by default,
 while allowing "--am" option to go back to the traditional "am"
 backend.

 Waiting for reviews and/or Acks.
 cf. <CABPp-BHONuRyt8VJqRuoCF2rGYZ5EhH9KJXQZ3NO69rYwA5J3g@mail.gmail.com>


* jk/packfile-reuse-cleanup (2020-01-23) 12 commits
  (merged to 'next' on 2020-02-07 at c543bc27fb)
 + pack-bitmap: don't rely on bitmap_git->reuse_objects
 + pack-objects: add checks for duplicate objects
 + pack-objects: improve partial packfile reuse
 + builtin/pack-objects: introduce obj_is_packed()
 + pack-objects: introduce pack.allowPackReuse
 + csum-file: introduce hashfile_total()
 + pack-bitmap: simplify bitmap_has_oid_in_uninteresting()
 + pack-bitmap: uninteresting oid can be outside bitmapped packfile
 + pack-bitmap: introduce bitmap_walk_contains()
 + ewah/bitmap: introduce bitmap_word_alloc()
 + packfile: expose get_delta_base()
 + builtin/pack-objects: report reused packfile objects

 The way "git pack-objects" reuses objects stored in existing pack
 to generate its result has been improved.

 Will merge to 'master'.

--------------------------------------------------
[Discarded]

* jc/format-patch-delay-message-id (2019-04-05) 1 commit
 . format-patch: move message-id and related headers to the end

 The location "git format-patch --thread" adds the Message-Id:
 header in the series of header fields has been moved down, which
 may help working around a suspected bug in GMail MSA, reported at
 <CAHk-=whP1stFZNAaJiMi5eZ9rj0MRt20Y_yHVczZPH+O01d+sA@mail.gmail.com>

 Was waiting for feedback to see if it truly helps.


* es/pathspec-f-f-grep (2020-01-13) 1 commit
 . grep: support the --pathspec-from-file option

 "git grep" learned the "--pathspec-from-file" command line
 option.

 Getting tired of waiting for review responses.
 cf. <20191204203911.237056-1-emilyshaffer@google.com>


* ma/config-bool-valex (2019-11-14) 8 commits
 . builtin/config: die if "value_regex" doesn't canonicalize as boolean
 . builtin/config: warn if "value_regex" doesn't canonicalize as boolean
 . builtin/config: canonicalize "value_regex" with `--type=bool-or-int`
 . builtin/config: canonicalize "value_regex" with `--type=bool`
 . builtin/config: collect "value_regexp" data in a struct
 . builtin/config: extract `handle_value_regex()` from `get_value()`
 . t1300: modernize part of script
 . config: make `git_parse_maybe_bool_text()` public

 "git config" can be told to affect the existing entries that
 "match" the given value via its value_regex argument.  It learned
 to normalize the value set in the configuration and the value given
 from the command line before computing they "match", e.g. "true" in
 the configuration file can now match with "yes" given from the
 command line.

 Retracted for now.
 cf. <CAN0heSpxhoAqSvN_TJHPntSagx3oA4s7iUebHcsYML8NSYwfUA@mail.gmail.com>


* ds/fsmonitor-testing (2019-12-09) 8 commits
 . test-lib: clear watchman watches at test completion
 . t7519: disable external GIT_TEST_FSMONITOR variable
 . t7063: disable fsmonitor with status cache
 . tests: disable fsmonitor in submodule tests
 . t3030-merge-recursive.sh: disable fsmonitor when tweaking GIT_WORK_TREE
 . t1301-shared-repo.sh: disable FSMONITOR
 . fsmonitor: do not output to stderr for tests
 . fsmonitor: disable in a bare repo

 Updates around testing fsmoitor integration.

 Retracted for now.
 cf. <a780fe83-c82c-c8fa-3f8d-5db9a7886875@gmail.com>


* jn/unknown-index-extensions (2018-11-21) 2 commits
 . index: offer advice for unknown index extensions
 . index: do not warn about unrecognized extensions

 A bit too alarming warning given when unknown index extensions
 exist is getting revamped.

 Getting tired of waiting for a reroll.


* js/protocol-advertise-multi (2018-12-28) 1 commit
 . protocol: advertise multiple supported versions

 The transport layer has been updated so that the protocol version
 used can be negotiated between the parties, by the initiator
 listing the protocol versions it is willing to talk, and the other
 side choosing from one of them.

 Getting tired of waiting for a reroll.
 cf. <CANq=j3u-zdb_FvNJGPCmygNMScseav63GhVvBX3NcVS4f7TejA@mail.gmail.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* bw/remote-rename-update-config, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-12 21:58 What's cooking in git.git (Feb 2020, #03; Wed, 12) Junio C Hamano
@ 2020-02-13 12:26 ` Johannes Schindelin
  2020-02-13 13:02 ` yz/p4-py3, " Johannes Schindelin
  2020-02-16  4:42 ` Elijah Newren
  2 siblings, 0 replies; 16+ messages in thread
From: Johannes Schindelin @ 2020-02-13 12:26 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

Hi Junio,

On Wed, 12 Feb 2020, Junio C Hamano wrote:

> * bw/remote-rename-update-config (2020-02-10) 6 commits
>  - remote rename/remove: gently handle remote.pushDefault config
>  - config: provide access to the current line number
>  - remote rename/remove: handle branch.<name>.pushRemote config values
>  - remote: clean-up config callback
>  - remote: clean-up by returning early to avoid one indentation
>  - pull --rebase/remote rename: document and honor single-letter abbreviations rebase types
>  (this branch uses mr/show-config-scope; is tangled with es/bugreport.)
>
>  "git remote rename X Y" needs to adjust configuration variables
>  (e.g. branch.<name>.remote) whose value used to be X to Y.
>  branch.<name>.pushRemote is now also updated.
>
>  Will merge to 'next'?

I think so, yes.

Thanks,
Dscho

^ permalink raw reply	[flat|nested] 16+ messages in thread

* yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-12 21:58 What's cooking in git.git (Feb 2020, #03; Wed, 12) Junio C Hamano
  2020-02-13 12:26 ` bw/remote-rename-update-config, was " Johannes Schindelin
@ 2020-02-13 13:02 ` Johannes Schindelin
  2020-02-13 16:06   ` Junio C Hamano
  2020-02-16  4:42 ` Elijah Newren
  2 siblings, 1 reply; 16+ messages in thread
From: Johannes Schindelin @ 2020-02-13 13:02 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

Hi,

On Wed, 12 Feb 2020, Junio C Hamano wrote:

> * yz/p4-py3 (2020-01-15) 14 commits
>  . ci: also run linux-gcc pipeline with python3.5 environment
>  - git-p4: use python3's input() everywhere
>  - git-p4: simplify regex pattern generation for parsing diff-tree
>  - git-p4: use dict.items() iteration for python3 compatibility
>  - git-p4: use functools.reduce instead of reduce
>  - git-p4: fix freezing while waiting for fast-import progress
>  - git-p4: use marshal format version 2 when sending to p4
>  - git-p4: open .gitp4-usercache.txt in text mode
>  - git-p4: convert path to unicode before processing them
>  - git-p4: encode/decode communication with git for python3
>  - git-p4: encode/decode communication with p4 for python3
>  - git-p4: remove string type aliasing
>  - git-p4: change the expansion test from basestring to list
>  - git-p4: make python2.7 the oldest supported version
>
>  Update "git p4" to work with Python 3.
>
>  Hold.
>  The last step is too wasteful to run full tests twice.
>  cf. <20200122235333.GA6837@szeder.dev>
>  cf. <20200123175645.GF6837@szeder.dev>

All right, all right, all right! If we cannot find any better way than to
just use Python2 in -clang and Python3 in -gcc (or was it the other way
round, I forget), then we cannot find any better way, and I won't hold
this up any longer.

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-13 13:02 ` yz/p4-py3, " Johannes Schindelin
@ 2020-02-13 16:06   ` Junio C Hamano
  2020-02-13 21:18     ` Junio C Hamano
  0 siblings, 1 reply; 16+ messages in thread
From: Junio C Hamano @ 2020-02-13 16:06 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: git, Yang Zhao, SZEDER Gábor

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Wed, 12 Feb 2020, Junio C Hamano wrote:
>
>> * yz/p4-py3 (2020-01-15) 14 commits
>>  . ci: also run linux-gcc pipeline with python3.5 environment
>>  - git-p4: use python3's input() everywhere
>>  ...
>>
>>  Update "git p4" to work with Python 3.
>>
>>  Hold.
>>  The last step is too wasteful to run full tests twice.
>>  cf. <20200122235333.GA6837@szeder.dev>
>>  cf. <20200123175645.GF6837@szeder.dev>
>
> All right, all right, all right! If we cannot find any better way than to
> just use Python2 in -clang and Python3 in -gcc (or was it the other way
> round, I forget), then we cannot find any better way, and I won't hold
> this up any longer.

OK, any one of you wants to do the honors of wrapping up the
proposed patch with a log message to replace the tip commit to allow
us to move forward?

Thanks.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-13 16:06   ` Junio C Hamano
@ 2020-02-13 21:18     ` Junio C Hamano
  2020-02-14  4:17       ` Junio C Hamano
  2020-03-10 17:38       ` SZEDER Gábor
  0 siblings, 2 replies; 16+ messages in thread
From: Junio C Hamano @ 2020-02-13 21:18 UTC (permalink / raw)
  To: SZEDER Gábor; +Cc: git, Yang Zhao, Johannes Schindelin

Junio C Hamano <gitster@pobox.com> writes:

> OK, any one of you wants to do the honors of wrapping up the
> proposed patch with a log message to replace the tip commit to allow
> us to move forward?


So the diff was taken from <20200123175645.GF6837@szeder.dev>; with
Szeder's SoB (and possibly wordsmithing the log message) let's tie
this loose end.

Thanks.

-- >8 --

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Thu, 23 Jan 2020 18:56:45 +0100
Subject: [PATCH] ci: use python3 in linux-gcc and osx-gcc and python2 elsewhere

Python2 reached end of life, and we have been preparing git-p4
(which is the sole in-tree user of Python) to work with Python3
but we haven't told our CI jobs to use Python3 anywhere yet.

Pick two jobs and use Python3 there, while leaving other jobs
to still stick to Python2 for now.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ci/lib.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ci/lib.sh b/ci/lib.sh
index a90d0dc0fd..c3a8cd2104 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -162,6 +162,9 @@ linux-clang|linux-gcc)
 	if [ "$jobname" = linux-gcc ]
 	then
 		export CC=gcc-8
+		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
+	else
+		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
 	fi
 
 	export GIT_TEST_HTTPD=true
@@ -182,6 +185,9 @@ osx-clang|osx-gcc)
 	if [ "$jobname" = osx-gcc ]
 	then
 		export CC=gcc-9
+		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
+	else
+		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
 	fi
 
 	# t9810 occasionally fails on Travis CI OS X
-- 
2.25.0-462-gba6e6679b4


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-13 21:18     ` Junio C Hamano
@ 2020-02-14  4:17       ` Junio C Hamano
  2020-02-14  5:15         ` Denton Liu
  2020-03-10 17:38       ` SZEDER Gábor
  1 sibling, 1 reply; 16+ messages in thread
From: Junio C Hamano @ 2020-02-14  4:17 UTC (permalink / raw)
  To: Yang Zhao
  Cc: git, SZEDER Gábor, Johannes Schindelin, Emily Shaffer,
	Han-Wen Nienhuys

Junio C Hamano <gitster@pobox.com> writes:

> So the diff was taken from <20200123175645.GF6837@szeder.dev>; with
> Szeder's SoB (and possibly wordsmithing the log message) let's tie
> this loose end.

Now we are running some tests under py3, we seem to be failing the
tip of 'pu'

    https://travis-ci.org/git/git/jobs/650160479

that is getting a SyntaxError.

    if message.find(separatorLine) <> -1:

There are other breakages whose causes are already identified in the
recent list messages, e.g.

    https://travis-ci.org/git/git/jobs/650160481

is due to a non-portable sed invocation in the bugreport topic,

    https://travis-ci.org/git/git/jobs/650160486

is also due to the same topic, and

    https://travis-ci.org/git/git/jobs/650160483

is due to the forbidden "for (type var = init; ...)" construct in
new C code.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-14  4:17       ` Junio C Hamano
@ 2020-02-14  5:15         ` Denton Liu
  2020-02-14 14:39           ` Ben Keene
  0 siblings, 1 reply; 16+ messages in thread
From: Denton Liu @ 2020-02-14  5:15 UTC (permalink / raw)
  To: Junio C Hamano
  Cc: Yang Zhao, git, SZEDER Gábor, Johannes Schindelin,
	Emily Shaffer, Han-Wen Nienhuys, Ben Keene

Hi Junio,

On Thu, Feb 13, 2020 at 08:17:39PM -0800, Junio C Hamano wrote:
> Now we are running some tests under py3, we seem to be failing the
> tip of 'pu'
> 
>     https://travis-ci.org/git/git/jobs/650160479
> 
> that is getting a SyntaxError.
> 
>     if message.find(separatorLine) <> -1:

This change comes from 'git-p4: restructure code in submit' in
'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
operator. In Python 2, this is valid but in Python 3, it was removed.

We can simply replace the `<>` with `!=` which is the new way of
writing "not equals".

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-14  5:15         ` Denton Liu
@ 2020-02-14 14:39           ` Ben Keene
  2020-02-14 16:18             ` Junio C Hamano
  2020-02-14 17:01             ` Junio C Hamano
  0 siblings, 2 replies; 16+ messages in thread
From: Ben Keene @ 2020-02-14 14:39 UTC (permalink / raw)
  To: Denton Liu, Junio C Hamano
  Cc: Yang Zhao, git, SZEDER Gábor, Johannes Schindelin,
	Emily Shaffer, Han-Wen Nienhuys


On 2/14/2020 12:15 AM, Denton Liu wrote:
> This change comes from 'git-p4: restructure code in submit' in
> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
> operator. In Python 2, this is valid but in Python 3, it was removed.
>
> We can simply replace the `<>` with `!=` which is the new way of
> writing "not equals".
Absolutely. I'm committing the change now.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-14 14:39           ` Ben Keene
@ 2020-02-14 16:18             ` Junio C Hamano
  2020-02-14 17:01             ` Junio C Hamano
  1 sibling, 0 replies; 16+ messages in thread
From: Junio C Hamano @ 2020-02-14 16:18 UTC (permalink / raw)
  To: Ben Keene
  Cc: Denton Liu, Yang Zhao, git, SZEDER Gábor,
	Johannes Schindelin, Emily Shaffer, Han-Wen Nienhuys

Ben Keene <seraphire@gmail.com> writes:

> On 2/14/2020 12:15 AM, Denton Liu wrote:
>> This change comes from 'git-p4: restructure code in submit' in
>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>
>> We can simply replace the `<>` with `!=` which is the new way of
>> writing "not equals".
> Absolutely. I'm committing the change now.

Alright.  So the replacement from Szeder for the yz/p4-py3 topic is
OK for everybody?  It still needs a sign-off, though.

Thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-14 14:39           ` Ben Keene
  2020-02-14 16:18             ` Junio C Hamano
@ 2020-02-14 17:01             ` Junio C Hamano
  2020-02-14 17:05               ` Ben Keene
  1 sibling, 1 reply; 16+ messages in thread
From: Junio C Hamano @ 2020-02-14 17:01 UTC (permalink / raw)
  To: Ben Keene
  Cc: Denton Liu, Yang Zhao, git, SZEDER Gábor,
	Johannes Schindelin, Emily Shaffer, Han-Wen Nienhuys

Ben Keene <seraphire@gmail.com> writes:

> On 2/14/2020 12:15 AM, Denton Liu wrote:
>> This change comes from 'git-p4: restructure code in submit' in
>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>
>> We can simply replace the `<>` with `!=` which is the new way of
>> writing "not equals".
> Absolutely. I'm committing the change now.

Thanks.

I didn't mean that the use of <> was the only bug in 'pu' wrt Python
3.  I see you sent a new round out, but has it been tested under
Python 3 already?  Just checking to set my expectation right.


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-14 17:01             ` Junio C Hamano
@ 2020-02-14 17:05               ` Ben Keene
  2020-02-14 18:10                 ` Junio C Hamano
  0 siblings, 1 reply; 16+ messages in thread
From: Ben Keene @ 2020-02-14 17:05 UTC (permalink / raw)
  To: Junio C Hamano
  Cc: Denton Liu, Yang Zhao, git, SZEDER Gábor,
	Johannes Schindelin, Emily Shaffer, Han-Wen Nienhuys


On 2/14/2020 12:01 PM, Junio C Hamano wrote:
> Ben Keene <seraphire@gmail.com> writes:
>
>> On 2/14/2020 12:15 AM, Denton Liu wrote:
>>> This change comes from 'git-p4: restructure code in submit' in
>>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>>
>>> We can simply replace the `<>` with `!=` which is the new way of
>>> writing "not equals".
>> Absolutely. I'm committing the change now.
> Thanks.
>
> I didn't mean that the use of <> was the only bug in 'pu' wrt Python
> 3.  I see you sent a new round out, but has it been tested under
> Python 3 already?  Just checking to set my expectation right.
I have not been able to test my changes under Py3. Unfortunately I
don't have the bandwidth at present to incorporate Yang's code into
this code for testing. I've been having to work with Python 2 at
present and using my changes locally.  I have tried to not use Python2
only code, but cross compatible code but I'm not sure what other
errors might be present.

I'm fine if this needs to stay pending until Yang is complete and
I can then retest with the new code.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-14 17:05               ` Ben Keene
@ 2020-02-14 18:10                 ` Junio C Hamano
  0 siblings, 0 replies; 16+ messages in thread
From: Junio C Hamano @ 2020-02-14 18:10 UTC (permalink / raw)
  To: Ben Keene
  Cc: Denton Liu, Yang Zhao, git, SZEDER Gábor,
	Johannes Schindelin, Emily Shaffer, Han-Wen Nienhuys

Ben Keene <seraphire@gmail.com> writes:

> On 2/14/2020 12:01 PM, Junio C Hamano wrote:
>> Ben Keene <seraphire@gmail.com> writes:
>>
>>> On 2/14/2020 12:15 AM, Denton Liu wrote:
>>>> This change comes from 'git-p4: restructure code in submit' in
>>>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>>>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>>>
>>>> We can simply replace the `<>` with `!=` which is the new way of
>>>> writing "not equals".
>>> Absolutely. I'm committing the change now.
>> Thanks.
>>
>> I didn't mean that the use of <> was the only bug in 'pu' wrt Python
>> 3.  I see you sent a new round out, but has it been tested under
>> Python 3 already?  Just checking to set my expectation right.
> I have not been able to test my changes under Py3. Unfortunately I
> don't have the bandwidth at present to incorporate Yang's code into
> this code for testing. I've been having to work with Python 2 at
> present and using my changes locally.  I have tried to not use Python2
> only code, but cross compatible code but I'm not sure what other
> errors might be present.
>
> I'm fine if this needs to stay pending until Yang is complete and
> I can then retest with the new code.

Nah, I'd have replaced and rebuilt 'pu' anyway.  I just wanted to
know how much I should be surprised if I saw any other Python3
issues when Travis sees the updated 'pu' later today.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-12 21:58 What's cooking in git.git (Feb 2020, #03; Wed, 12) Junio C Hamano
  2020-02-13 12:26 ` bw/remote-rename-update-config, was " Johannes Schindelin
  2020-02-13 13:02 ` yz/p4-py3, " Johannes Schindelin
@ 2020-02-16  4:42 ` Elijah Newren
  2020-02-17  7:38   ` Pratyush Yadav
  2 siblings, 1 reply; 16+ messages in thread
From: Elijah Newren @ 2020-02-16  4:42 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List

On Wed, Feb 12, 2020 at 2:02 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Here are the topics that have been cooking.  Commits prefixed with
> '-' are only in 'pu' (proposed updates) while commits prefixed with
> '+' are in 'next'.  The ones marked with '.' do not appear in any of
> the integration branches, but I am still holding onto them.
>
> The fourth batch of topics are now in 'master'.

Somewhat of a tangent, but is there any plan to update tinyurl.com/gitCal?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-16  4:42 ` Elijah Newren
@ 2020-02-17  7:38   ` Pratyush Yadav
  0 siblings, 0 replies; 16+ messages in thread
From: Pratyush Yadav @ 2020-02-17  7:38 UTC (permalink / raw)
  To: Elijah Newren; +Cc: Junio C Hamano, Git Mailing List

On 15/02/20 08:42PM, Elijah Newren wrote:
> On Wed, Feb 12, 2020 at 2:02 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Here are the topics that have been cooking.  Commits prefixed with
> > '-' are only in 'pu' (proposed updates) while commits prefixed with
> > '+' are in 'next'.  The ones marked with '.' do not appear in any of
> > the integration branches, but I am still holding onto them.
> >
> > The fourth batch of topics are now in 'master'.
> 
> Somewhat of a tangent, but is there any plan to update tinyurl.com/gitCal?

Heh, so I'm not the only person who noticed ;-)

-- 
Regards,
Pratyush Yadav

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-02-13 21:18     ` Junio C Hamano
  2020-02-14  4:17       ` Junio C Hamano
@ 2020-03-10 17:38       ` SZEDER Gábor
  2020-03-10 18:29         ` Junio C Hamano
  1 sibling, 1 reply; 16+ messages in thread
From: SZEDER Gábor @ 2020-03-10 17:38 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Yang Zhao, Johannes Schindelin

On Thu, Feb 13, 2020 at 01:18:52PM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > OK, any one of you wants to do the honors of wrapping up the
> > proposed patch with a log message to replace the tip commit to allow
> > us to move forward?
> 
> 
> So the diff was taken from <20200123175645.GF6837@szeder.dev>; with
> Szeder's SoB (and possibly wordsmithing the log message) let's tie
> this loose end.

Here is the SoB and the wordsmithed commit message.

> Thanks.
> 
> -- >8 --
> 
> From: SZEDER Gábor <szeder.dev@gmail.com>
> Date: Thu, 23 Jan 2020 18:56:45 +0100
> Subject: [PATCH] ci: use python3 in linux-gcc and osx-gcc and python2 elsewhere
> 
> Python2 reached end of life, and we have been preparing git-p4
> (which is the sole in-tree user of Python) to work with Python3
> but we haven't told our CI jobs to use Python3 anywhere yet.
> 
> Pick two jobs and use Python3 there, while leaving other jobs
> to still stick to Python2 for now.

  --- >8 ---

Subject: [PATCH] ci: use python3 in linux-gcc and osx-gcc and python2 elsewhere

Python2 reached end of life, and we have been preparing our Python
scripts to work with Python3.  'git p4', the main in-tree user of
Python, has just received a number of compatibility updates.  Our
other notable Python script 'contrib/svn-fe/svnrdump_sim.py' is only
used in 't9020-remote-svn.sh', and is apparently already compatible
with both Python2 and 3.

Our CI jobs currently only use Python2.  We want to make sure that
these Python scripts do indeed work with Python3, and we also want to
make sure that these scripts keep working with Python2 as well, for
the sake of some older LTS/Enterprise setups.

Therefore, pick two jobs and use Python3 there, while leaving other
jobs to still stick to Python2 for now.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

  --- >8 ---


> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  ci/lib.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ci/lib.sh b/ci/lib.sh
> index a90d0dc0fd..c3a8cd2104 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -162,6 +162,9 @@ linux-clang|linux-gcc)
>  	if [ "$jobname" = linux-gcc ]
>  	then
>  		export CC=gcc-8
> +		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
> +	else
> +		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
>  	fi
>  
>  	export GIT_TEST_HTTPD=true
> @@ -182,6 +185,9 @@ osx-clang|osx-gcc)
>  	if [ "$jobname" = osx-gcc ]
>  	then
>  		export CC=gcc-9
> +		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
> +	else
> +		MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
>  	fi
>  
>  	# t9810 occasionally fails on Travis CI OS X
> -- 
> 2.25.0-462-gba6e6679b4
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
  2020-03-10 17:38       ` SZEDER Gábor
@ 2020-03-10 18:29         ` Junio C Hamano
  0 siblings, 0 replies; 16+ messages in thread
From: Junio C Hamano @ 2020-03-10 18:29 UTC (permalink / raw)
  To: SZEDER Gábor; +Cc: git, Yang Zhao, Johannes Schindelin

SZEDER Gábor <szeder.dev@gmail.com> writes:

> Here is the SoB and the wordsmithed commit message.
> ...
> Subject: [PATCH] ci: use python3 in linux-gcc and osx-gcc and python2 elsewhere
>
> Python2 reached end of life, and we have been preparing our Python
> scripts to work with Python3.  'git p4', the main in-tree user of
> Python, has just received a number of compatibility updates.  Our
> other notable Python script 'contrib/svn-fe/svnrdump_sim.py' is only
> used in 't9020-remote-svn.sh', and is apparently already compatible
> with both Python2 and 3.
>
> Our CI jobs currently only use Python2.  We want to make sure that
> these Python scripts do indeed work with Python3, and we also want to
> make sure that these scripts keep working with Python2 as well, for
> the sake of some older LTS/Enterprise setups.
>
> Therefore, pick two jobs and use Python3 there, while leaving other
> jobs to still stick to Python2 for now.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Nicely written.  Thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2020-03-10 18:29 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 21:58 What's cooking in git.git (Feb 2020, #03; Wed, 12) Junio C Hamano
2020-02-13 12:26 ` bw/remote-rename-update-config, was " Johannes Schindelin
2020-02-13 13:02 ` yz/p4-py3, " Johannes Schindelin
2020-02-13 16:06   ` Junio C Hamano
2020-02-13 21:18     ` Junio C Hamano
2020-02-14  4:17       ` Junio C Hamano
2020-02-14  5:15         ` Denton Liu
2020-02-14 14:39           ` Ben Keene
2020-02-14 16:18             ` Junio C Hamano
2020-02-14 17:01             ` Junio C Hamano
2020-02-14 17:05               ` Ben Keene
2020-02-14 18:10                 ` Junio C Hamano
2020-03-10 17:38       ` SZEDER Gábor
2020-03-10 18:29         ` Junio C Hamano
2020-02-16  4:42 ` Elijah Newren
2020-02-17  7:38   ` Pratyush Yadav

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git