git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Keene <seraphire@gmail.com>
Cc: "Denton Liu" <liu.denton@gmail.com>,
	"Yang Zhao" <yang.zhao@skyboxlabs.com>,
	git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Emily Shaffer" <emilyshaffer@google.com>,
	"Han-Wen Nienhuys" <hanwen@google.com>
Subject: Re: yz/p4-py3, was Re: What's cooking in git.git (Feb 2020, #03; Wed, 12)
Date: Fri, 14 Feb 2020 10:10:44 -0800	[thread overview]
Message-ID: <xmqqimk9nior.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <9d1d3f2e-fef2-bcba-8065-c33ff6c5c0c3@gmail.com> (Ben Keene's message of "Fri, 14 Feb 2020 12:05:15 -0500")

Ben Keene <seraphire@gmail.com> writes:

> On 2/14/2020 12:01 PM, Junio C Hamano wrote:
>> Ben Keene <seraphire@gmail.com> writes:
>>
>>> On 2/14/2020 12:15 AM, Denton Liu wrote:
>>>> This change comes from 'git-p4: restructure code in submit' in
>>>> 'bk/p4-pre-edit-changelist' which introduced the use of the `<>`
>>>> operator. In Python 2, this is valid but in Python 3, it was removed.
>>>>
>>>> We can simply replace the `<>` with `!=` which is the new way of
>>>> writing "not equals".
>>> Absolutely. I'm committing the change now.
>> Thanks.
>>
>> I didn't mean that the use of <> was the only bug in 'pu' wrt Python
>> 3.  I see you sent a new round out, but has it been tested under
>> Python 3 already?  Just checking to set my expectation right.
> I have not been able to test my changes under Py3. Unfortunately I
> don't have the bandwidth at present to incorporate Yang's code into
> this code for testing. I've been having to work with Python 2 at
> present and using my changes locally.  I have tried to not use Python2
> only code, but cross compatible code but I'm not sure what other
> errors might be present.
>
> I'm fine if this needs to stay pending until Yang is complete and
> I can then retest with the new code.

Nah, I'd have replaced and rebuilt 'pu' anyway.  I just wanted to
know how much I should be surprised if I saw any other Python3
issues when Travis sees the updated 'pu' later today.

  reply	other threads:[~2020-02-14 18:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 21:58 What's cooking in git.git (Feb 2020, #03; Wed, 12) Junio C Hamano
2020-02-13 12:26 ` bw/remote-rename-update-config, was " Johannes Schindelin
2020-02-13 13:02 ` yz/p4-py3, " Johannes Schindelin
2020-02-13 16:06   ` Junio C Hamano
2020-02-13 21:18     ` Junio C Hamano
2020-02-14  4:17       ` Junio C Hamano
2020-02-14  5:15         ` Denton Liu
2020-02-14 14:39           ` Ben Keene
2020-02-14 16:18             ` Junio C Hamano
2020-02-14 17:01             ` Junio C Hamano
2020-02-14 17:05               ` Ben Keene
2020-02-14 18:10                 ` Junio C Hamano [this message]
2020-03-10 17:38       ` SZEDER Gábor
2020-03-10 18:29         ` Junio C Hamano
2020-02-16  4:42 ` Elijah Newren
2020-02-17  7:38   ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqimk9nior.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=hanwen@google.com \
    --cc=liu.denton@gmail.com \
    --cc=seraphire@gmail.com \
    --cc=szeder.dev@gmail.com \
    --cc=yang.zhao@skyboxlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).