From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Carlo Arenas <carenas@gmail.com>, git@vger.kernel.org
Subject: Re: preparing for 2.34.1
Date: Mon, 22 Nov 2021 14:42:16 -0800 [thread overview]
Message-ID: <xmqqmtlvbynr.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2111222319100.63@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 22 Nov 2021 23:28:22 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> The quickest workaround for this is probably to special-case the editor
> `echo`:
"GIT_EDITOR=: git cmd" would also be a common trick people would use
to bypass editor and take whatever is given as an initial template.
> However, I could imagine that other scenarios call for an editor that
> _also_ does not run in the terminal, and where also no real terminal is
> available for saving and restoring.
>
> I was tempted to suggest an `isatty(2)`, but that probably comes with its
> own problems, too.
I think isatty(2) is pretty much our synonym to "are we talking to
an end-user sitting in front of the terminal". Mostly we use it as
a way to control the progress bars, and use of editor on terminal
would be in line with these existing uses.
next prev parent reply other threads:[~2021-11-22 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 17:37 preparing for 2.34.1 Junio C Hamano
2021-11-22 20:51 ` Carlo Arenas
2021-11-22 22:28 ` Johannes Schindelin
2021-11-22 22:42 ` Junio C Hamano [this message]
2021-11-22 23:30 ` Johannes Schindelin
2021-11-22 23:51 ` rsbecker
2021-11-22 22:50 ` Carlo Arenas
2021-11-22 21:50 ` Derrick Stolee
2021-11-22 22:45 ` Junio C Hamano
2021-11-23 17:18 ` preparing for 2.34.1 (2nd round) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtlvbynr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).