From: Carlo Arenas <carenas@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, phillip.wood123@gmail.com
Subject: Re: preparing for 2.34.1
Date: Mon, 22 Nov 2021 14:50:08 -0800 [thread overview]
Message-ID: <CAPUEsph+F5inaga266xdFoc6KibjFo7hYh0ycdAkM9Q8yk5Ryg@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2111222319100.63@tvgsbejvaqbjf.bet>
On Mon, Nov 22, 2021 at 2:28 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> I was tempted to suggest an `isatty(2)`, but that probably comes with its
> own problems, too.
I went with isatty(1) in the suggested minimal bugfix[1] since I think
it is safe to assume that no one that doesn't have stdout connected to
a terminal should even care if the invoking editor dies and messes
with their terminal, and hopefully whoever is hacking git commands
that invoke an editor to read its output, is actually not doing it
through a tty but a pipe.
What problems do you foresee with isatty?, the current code already
checks for errors on accessing the console, but as Phillip
suggested[2] in that thread a signal might be generated for some of
those errors when the terminal is shared with other processes.
Carlo
CC: +Phillip
[1] https://lore.kernel.org/git/20211122222850.674-1-carenas@gmail.com/
[2] https://lore.kernel.org/git/04ab7301-ea34-476c-eae4-4044fef74b91@gmail.com/T/#u
next prev parent reply other threads:[~2021-11-22 22:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 17:37 preparing for 2.34.1 Junio C Hamano
2021-11-22 20:51 ` Carlo Arenas
2021-11-22 22:28 ` Johannes Schindelin
2021-11-22 22:42 ` Junio C Hamano
2021-11-22 23:30 ` Johannes Schindelin
2021-11-22 23:51 ` rsbecker
2021-11-22 22:50 ` Carlo Arenas [this message]
2021-11-22 21:50 ` Derrick Stolee
2021-11-22 22:45 ` Junio C Hamano
2021-11-23 17:18 ` preparing for 2.34.1 (2nd round) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPUEsph+F5inaga266xdFoc6KibjFo7hYh0ycdAkM9Q8yk5Ryg@mail.gmail.com \
--to=carenas@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).