git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Carlo Arenas <carenas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: preparing for 2.34.1
Date: Mon, 22 Nov 2021 12:51:55 -0800	[thread overview]
Message-ID: <CAPUEsphNH9pfQoHqVgJfkQCU-Li45dz4QtGtDjWu5bDV9A3PEg@mail.gmail.com> (raw)
In-Reply-To: <xmqqr1b8gkhg.fsf@gitster.g>

On Mon, Nov 22, 2021 at 11:54 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> There are a few topics [*] to fix regressions introduced in the
> previous cycle

There was another regression report[1] that I just fished out of my
spam folder and that I introduced in 3d411afabc (editor: save and
reset terminal after calling EDITOR, 2021-10-05), but that I have not
yet produced a fix for or fully understood.

The gist is that some people seem to be using a hack[2] dscho posted a
few years ago to get info from git programmatically and I just didn't
expect someone would try to invoke the EDITOR unless they had a
terminal, so the fix might be to just add an isatty(0) call, but
reverting that commit would be also an option.

Carlo

[1] https://lore.kernel.org/git/ee302c98-da27-da43-e684-c7ec8b225360@gmx.net/
[2] https://yhbt.net/lore/all/nycvar.QRO.7.76.6.1903221436590.41@tvgsbejvaqbjf.bet/T/

  reply	other threads:[~2021-11-22 20:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 17:37 preparing for 2.34.1 Junio C Hamano
2021-11-22 20:51 ` Carlo Arenas [this message]
2021-11-22 22:28   ` Johannes Schindelin
2021-11-22 22:42     ` Junio C Hamano
2021-11-22 23:30       ` Johannes Schindelin
2021-11-22 23:51         ` rsbecker
2021-11-22 22:50     ` Carlo Arenas
2021-11-22 21:50 ` Derrick Stolee
2021-11-22 22:45   ` Junio C Hamano
2021-11-23 17:18 ` preparing for 2.34.1 (2nd round) Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPUEsphNH9pfQoHqVgJfkQCU-Li45dz4QtGtDjWu5bDV9A3PEg@mail.gmail.com \
    --to=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).