From: Junio C Hamano <gitster@pobox.com>
To: Brian Malehorn <bmalehorn@gmail.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] interpret-trailers: obey scissors lines
Date: Tue, 16 May 2017 15:42:05 +0900 [thread overview]
Message-ID: <xmqqlgpx1ewy.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170516060649.29110-1-bmalehorn@gmail.com> (Brian Malehorn's message of "Mon, 15 May 2017 23:06:48 -0700")
Brian Malehorn <bmalehorn@gmail.com> writes:
>> The mention of "'commit -v -s' works that way, too" was my attempt
>> to justify why it is OK to make this change unconditionally to
>> intepret-trailers, but I am still not 100% convinced with that
>> reasoning (or your original log message) that it is a safe thing to
>> do. It is not like its sole purpose is to serve as GIT_EDITOR for
>> the "git commit" command.
>
> Yup, this is a heuristic and it will sometimes hit false. But a far
> more grievous heuristic is ignoring all lines that begin with '#', yet
> we do that anyway for its convenience in editing commit messages. Since
> we already *partially* honor commit message syntax in
> interpret-trailers, we might as well *completely* honor it by parsing
> cut lines as well. At least, that's my reasoning.
I was primarily wondering if we want to protect this behind an
option to "interpret-trailers", instead of making this change
unconditionally. But your above reasoning makes sense to me.
Thanks.
next prev parent reply other threads:[~2017-05-16 6:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 5:03 [PATCH 0/3] interpret-trailers + commit -v bugfix Brian Malehorn
2017-05-12 5:03 ` [PATCH 1/3] mailinfo.c: is_scissors_line ends on newline Brian Malehorn
2017-05-12 8:31 ` Jeff King
2017-05-12 5:03 ` [PATCH 2/3] commit.c: add is_scissors_line Brian Malehorn
2017-05-12 8:40 ` Jeff King
2017-05-12 5:03 ` [PATCH 3/3] commit.c: skip scissors when computing trailers Brian Malehorn
2017-05-12 8:52 ` Jeff King
2017-05-12 9:00 ` [PATCH 0/3] interpret-trailers + commit -v bugfix Jeff King
2017-05-14 3:39 ` Brian Malehorn
2017-05-14 3:39 ` [PATCH] interpret-trailers: obey scissors lines Brian Malehorn
2017-05-14 3:56 ` Jeff King
2017-05-14 8:33 ` Brian Malehorn
2017-05-14 8:33 ` Brian Malehorn
2017-05-15 3:55 ` Junio C Hamano
2017-05-15 4:23 ` Junio C Hamano
2017-05-16 6:06 ` Brian Malehorn
2017-05-16 6:06 ` [PATCH] interpret-trailers: honor the cut line Brian Malehorn
2017-05-16 6:42 ` Junio C Hamano [this message]
2017-05-15 3:08 ` [PATCH] interpret-trailers: obey scissors lines Jeff King
2017-05-15 2:12 ` Junio C Hamano
2017-05-15 3:07 ` Jeff King
2017-05-15 3:32 ` Junio C Hamano
2017-05-15 3:33 ` Jeff King
2017-05-14 7:02 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgpx1ewy.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmalehorn@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).