From: Jeff King <peff@peff.net>
To: Brian Malehorn <bmalehorn@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] mailinfo.c: is_scissors_line ends on newline
Date: Fri, 12 May 2017 04:31:31 -0400 [thread overview]
Message-ID: <20170512083131.nb5zyurmeg6n5auo@sigill.intra.peff.net> (raw)
In-Reply-To: <20170512050347.30765-2-bmalehorn@gmail.com>
On Thu, May 11, 2017 at 10:03:45PM -0700, Brian Malehorn wrote:
> Needed to work with git interpret-trailers. Since "line" is, of course,
> a line, it will always end with "\n\0" and therefore we can safely end
> on "\n".
> [...]
> - for (c = line; *c; c++) {
> + for (c = line; *c != '\n'; c++) {
> if (isspace(*c)) {
Hrm. So I don't think this is _wrong_ per se, but the first thing we do
in the loop is check isspace(), which a newline should match. And you
can't see it from the diff context, but it always hits a continue, which
would then advance to the NUL and exit the loop.
So I'm puzzled why this change is necessary. Am I missing something?
We would increase the gap and perforation if we're in them, so I guess
it could have an impact on the line-length heuristics that come at the
end of the function. Is that it?
-Peff
next prev parent reply other threads:[~2017-05-12 8:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 5:03 [PATCH 0/3] interpret-trailers + commit -v bugfix Brian Malehorn
2017-05-12 5:03 ` [PATCH 1/3] mailinfo.c: is_scissors_line ends on newline Brian Malehorn
2017-05-12 8:31 ` Jeff King [this message]
2017-05-12 5:03 ` [PATCH 2/3] commit.c: add is_scissors_line Brian Malehorn
2017-05-12 8:40 ` Jeff King
2017-05-12 5:03 ` [PATCH 3/3] commit.c: skip scissors when computing trailers Brian Malehorn
2017-05-12 8:52 ` Jeff King
2017-05-12 9:00 ` [PATCH 0/3] interpret-trailers + commit -v bugfix Jeff King
2017-05-14 3:39 ` Brian Malehorn
2017-05-14 3:39 ` [PATCH] interpret-trailers: obey scissors lines Brian Malehorn
2017-05-14 3:56 ` Jeff King
2017-05-14 8:33 ` Brian Malehorn
2017-05-14 8:33 ` Brian Malehorn
2017-05-15 3:55 ` Junio C Hamano
2017-05-15 4:23 ` Junio C Hamano
2017-05-16 6:06 ` Brian Malehorn
2017-05-16 6:06 ` [PATCH] interpret-trailers: honor the cut line Brian Malehorn
2017-05-16 6:42 ` [PATCH] interpret-trailers: obey scissors lines Junio C Hamano
2017-05-15 3:08 ` Jeff King
2017-05-15 2:12 ` Junio C Hamano
2017-05-15 3:07 ` Jeff King
2017-05-15 3:32 ` Junio C Hamano
2017-05-15 3:33 ` Jeff King
2017-05-14 7:02 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512083131.nb5zyurmeg6n5auo@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmalehorn@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).