From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Ben Peart <Ben.Peart@microsoft.com>,
Jonathan Tan <jonathantanmy@google.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Stefan Beller <sbeller@google.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Mike Hommey <mh@glandium.org>,
Lars Schneider <larsxschneider@gmail.com>,
Eric Wong <e@80x24.org>,
Christian Couder <chriscool@tuxfamily.org>,
Jeff Hostetler <jeffhost@microsoft.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Beat Bolli <dev+git@drbeat.li>
Subject: Re: [PATCH v3 04/11] promisor-remote: add promisor_remote_reinit()
Date: Wed, 13 Mar 2019 13:28:03 +0900 [thread overview]
Message-ID: <xmqqlg1je6uk.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190312132959.11764-5-chriscool@tuxfamily.org> (Christian Couder's message of "Tue, 12 Mar 2019 14:29:52 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> From: Christian Couder <christian.couder@gmail.com>
>
> We will need to reinitialize the promisor remote configuration
> as we will make some changes to it in a later commit.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
At this point, turning "initialized" into a file-scope static, and
building reinit as
void promisor_remote_reinit(void)
{
initialized = 0;
... clear existing "promisor" entries ...
promisor_remote_init();
}
may make more sense.
> -static void promisor_remote_init(void)
> +static void promisor_remote_do_init(int force)
> {
> static int initialized;
>
> - if (initialized)
> + if (!force && initialized)
> return;
> initialized = 1;
>
> git_config(promisor_remote_config, NULL);
The promisors and promisors_tail would need to be reinitiazlied and
existing elements on the list purged. Otherwise, after removing an
entry from the configuration file, the entry will still stay around.
> }
>
> +static inline void promisor_remote_init(void)
> +{
> + promisor_remote_do_init(0);
> +}
> +
> +void promisor_remote_reinit(void)
> +{
> + promisor_remote_do_init(1);
> +}
> +
> struct promisor_remote *promisor_remote_find(const char *remote_name)
> {
> promisor_remote_init();
> diff --git a/promisor-remote.h b/promisor-remote.h
> index f9f5825417..f96722bc66 100644
> --- a/promisor-remote.h
> +++ b/promisor-remote.h
> @@ -10,6 +10,7 @@ struct promisor_remote {
> struct promisor_remote *next;
> };
>
> +extern void promisor_remote_reinit(void);
> extern struct promisor_remote *promisor_remote_new(const char *remote_name);
> extern struct promisor_remote *promisor_remote_find(const char *remote_name);
> extern int has_promisor_remote(void);
next prev parent reply other threads:[~2019-03-13 4:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 13:29 [PATCH v3 00/11] Many promisor remotes Christian Couder
2019-03-12 13:29 ` [PATCH v3 01/11] fetch-object: make functions return an error code Christian Couder
2019-03-12 13:29 ` [PATCH v3 02/11] Add initial support for many promisor remotes Christian Couder
2019-03-13 4:09 ` Junio C Hamano
2019-03-13 4:34 ` Junio C Hamano
2019-04-01 16:41 ` Christian Couder
2019-03-12 13:29 ` [PATCH v3 03/11] promisor-remote: implement promisor_remote_get_direct() Christian Couder
2019-03-13 4:23 ` Junio C Hamano
2019-04-01 16:41 ` Christian Couder
2019-03-12 13:29 ` [PATCH v3 04/11] promisor-remote: add promisor_remote_reinit() Christian Couder
2019-03-13 4:28 ` Junio C Hamano [this message]
2019-04-01 16:41 ` Christian Couder
2019-03-12 13:29 ` [PATCH v3 05/11] promisor-remote: use repository_format_partial_clone Christian Couder
2019-03-13 4:31 ` Junio C Hamano
2019-04-01 16:42 ` Christian Couder
2019-04-01 17:25 ` Junio C Hamano
2019-03-12 13:29 ` [PATCH v3 06/11] Use promisor_remote_get_direct() and has_promisor_remote() Christian Couder
2019-03-12 13:29 ` [PATCH v3 07/11] promisor-remote: parse remote.*.partialclonefilter Christian Couder
2019-03-12 13:29 ` [PATCH v3 08/11] builtin/fetch: remove unique promisor remote limitation Christian Couder
2019-03-12 13:29 ` [PATCH v3 09/11] t0410: test fetching from many promisor remotes Christian Couder
2019-03-12 13:29 ` [PATCH v3 10/11] partial-clone: add multiple remotes in the doc Christian Couder
2019-03-12 13:29 ` [PATCH v3 11/11] remote: add promisor and partial clone config to " Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg1je6uk.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Ben.Peart@microsoft.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=dev+git@drbeat.li \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=mh@glandium.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).