From: Junio C Hamano <gitster@pobox.com> To: Christian Couder <christian.couder@gmail.com> Cc: git@vger.kernel.org, Jeff King <peff@peff.net>, Ben Peart <Ben.Peart@microsoft.com>, Jonathan Tan <jonathantanmy@google.com>, Jonathan Nieder <jrnieder@gmail.com>, Stefan Beller <sbeller@google.com>, Nguyen Thai Ngoc Duy <pclouds@gmail.com>, Mike Hommey <mh@glandium.org>, Lars Schneider <larsxschneider@gmail.com>, Eric Wong <e@80x24.org>, Christian Couder <chriscool@tuxfamily.org>, Jeff Hostetler <jeffhost@microsoft.com>, Eric Sunshine <sunshine@sunshineco.com>, Beat Bolli <dev+git@drbeat.li> Subject: Re: [PATCH v3 03/11] promisor-remote: implement promisor_remote_get_direct() Date: Wed, 13 Mar 2019 13:23:58 +0900 Message-ID: <xmqqpnqve71d.fsf@gitster-ct.c.googlers.com> (raw) In-Reply-To: <20190312132959.11764-4-chriscool@tuxfamily.org> (Christian Couder's message of "Tue, 12 Mar 2019 14:29:51 +0100") Christian Couder <christian.couder@gmail.com> writes: > @@ -98,3 +99,19 @@ int has_promisor_remote(void) > { > return !!promisor_remote_find(NULL); > } > + > +int promisor_remote_get_direct(const struct object_id *oids, int oid_nr) > +{ > + struct promisor_remote *o; > + > + promisor_remote_init(); > + > + for (o = promisors; o; o = o->next) { > + if (fetch_objects(o->remote_name, oids, oid_nr) < 0) > + continue; > + return 0; Suppose the caller asks to fetch 3 objects, A, B and C, from two promisors. The first promisor can give you A and B but cannot give you C. The second promisor only can give you C. Does fetch_objects() return failure after attempting to fetch A, B and C from the first promisor? Then we go on to the second promisor but do we ask all three? That would mean the second promisor will also fail because it cannot give you A and B, and then the whole thing would fail. It would be nicer if the mechanism would allow us to fetch what is still missing from later promisor, perhaps. As the original "fetch" protocol only allows you to fetch a pack with everything you asked for in it, instead of feeding you a pack with best effort, I think the answer to the above is "it is very hard to improve over what we have here", but people may have interesting ideas ;-) > + } > + > + return -1; > +} > + Adding trailing blank line at the end? > diff --git a/promisor-remote.h b/promisor-remote.h > index bfbf7c0f21..f9f5825417 100644 > --- a/promisor-remote.h > +++ b/promisor-remote.h > @@ -13,5 +13,6 @@ struct promisor_remote { > extern struct promisor_remote *promisor_remote_new(const char *remote_name); > extern struct promisor_remote *promisor_remote_find(const char *remote_name); > extern int has_promisor_remote(void); > +extern int promisor_remote_get_direct(const struct object_id *oids, int oid_nr); > > #endif /* PROMISOR_REMOTE_H */
next prev parent reply other threads:[~2019-03-13 4:24 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-12 13:29 [PATCH v3 00/11] Many promisor remotes Christian Couder 2019-03-12 13:29 ` [PATCH v3 01/11] fetch-object: make functions return an error code Christian Couder 2019-03-12 13:29 ` [PATCH v3 02/11] Add initial support for many promisor remotes Christian Couder 2019-03-13 4:09 ` Junio C Hamano 2019-03-13 4:34 ` Junio C Hamano 2019-04-01 16:41 ` Christian Couder 2019-03-12 13:29 ` [PATCH v3 03/11] promisor-remote: implement promisor_remote_get_direct() Christian Couder 2019-03-13 4:23 ` Junio C Hamano [this message] 2019-04-01 16:41 ` Christian Couder 2019-03-12 13:29 ` [PATCH v3 04/11] promisor-remote: add promisor_remote_reinit() Christian Couder 2019-03-13 4:28 ` Junio C Hamano 2019-04-01 16:41 ` Christian Couder 2019-03-12 13:29 ` [PATCH v3 05/11] promisor-remote: use repository_format_partial_clone Christian Couder 2019-03-13 4:31 ` Junio C Hamano 2019-04-01 16:42 ` Christian Couder 2019-04-01 17:25 ` Junio C Hamano 2019-03-12 13:29 ` [PATCH v3 06/11] Use promisor_remote_get_direct() and has_promisor_remote() Christian Couder 2019-03-12 13:29 ` [PATCH v3 07/11] promisor-remote: parse remote.*.partialclonefilter Christian Couder 2019-03-12 13:29 ` [PATCH v3 08/11] builtin/fetch: remove unique promisor remote limitation Christian Couder 2019-03-12 13:29 ` [PATCH v3 09/11] t0410: test fetching from many promisor remotes Christian Couder 2019-03-12 13:29 ` [PATCH v3 10/11] partial-clone: add multiple remotes in the doc Christian Couder 2019-03-12 13:29 ` [PATCH v3 11/11] remote: add promisor and partial clone config to " Christian Couder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqpnqve71d.fsf@gitster-ct.c.googlers.com \ --to=gitster@pobox.com \ --cc=Ben.Peart@microsoft.com \ --cc=chriscool@tuxfamily.org \ --cc=christian.couder@gmail.com \ --cc=dev+git@drbeat.li \ --cc=e@80x24.org \ --cc=git@vger.kernel.org \ --cc=jeffhost@microsoft.com \ --cc=jonathantanmy@google.com \ --cc=jrnieder@gmail.com \ --cc=larsxschneider@gmail.com \ --cc=mh@glandium.org \ --cc=pclouds@gmail.com \ --cc=peff@peff.net \ --cc=sbeller@google.com \ --cc=sunshine@sunshineco.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git