From: Christian Couder <firstname.lastname@example.org> To: email@example.com Cc: Junio C Hamano <firstname.lastname@example.org>, Jeff King <email@example.com>, Ben Peart <Ben.Peart@microsoft.com>, Jonathan Tan <firstname.lastname@example.org>, Jonathan Nieder <email@example.com>, Stefan Beller <firstname.lastname@example.org>, Nguyen Thai Ngoc Duy <email@example.com>, Mike Hommey <firstname.lastname@example.org>, Lars Schneider <email@example.com>, Eric Wong <firstname.lastname@example.org>, Christian Couder <email@example.com>, Jeff Hostetler <firstname.lastname@example.org>, Eric Sunshine <email@example.com>, Beat Bolli <firstname.lastname@example.org> Subject: [PATCH v3 00/11] Many promisor remotes Date: Tue, 12 Mar 2019 14:29:48 +0100 [thread overview] Message-ID: <email@example.com> (raw) This path series is a follow up from the "remote odb" patch series that I sent last year, which were a follow up from previous series. See the links section for more information. The goal of this patch series is to make it possible to have and to fetch missing objects from multiple remotes instead of only one. For now the fetch order is the order of the remotes in the config, except for the remote specified by extensions.partialclone config option which comes last in the fetch order. I selected the name "Promisor remote" over "Partial clone remote" because it is shorter and because it is not only about cloning. The existing extensions.partialclone config option is respected, but it is not written in the config when a partial clone or fetch is made. Instead remote.<name>.promisor is set to "true". This may create a compatibility issue, but it makes it possible to start using many promisor remotes by just cloning and fetching from different remotes with partial clone filters. The compatibility issue could be resolved in a future iteration by just setting extensions.partialclone instead of remote.<name>.promisor the first time a promisor remote is used. In general I have tried to change as few things as possible. High level changes since the V2 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - remove the 2 first patches from V2 that have been sent and merged separately - improved commit message in patch 8/11 documentation patches - slightly improved cover letter As I got no comment on V2, I am not sure what to improve at this point. High level overview of this patch series ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - Patch 1/11: This patch, makes functions in fetch-object.c return an error code, which is necessary to later tell that they failed and try another promisor remote when there is more than one. This could also just be seen as a fix to these functions. - Patch 2/11: This introduces the minimum infrastructure for promisor remotes. - Patch 3/11, 4/11 and 5/11: This add a few missing bits in the promisor remote infrastructure that will be needed in the following patches. - Patch 6/11: This replaces the previous interface that used only one promisor remote defined in extensions.partialclone with the new interface created by the previous patches. - Patch 7/11: This replaces the way a partial clone filter was handled by a new way based on the previous patches that support more than one partial clone filter. - Patch 8/11: This patch removes the limitation in builtin/fetch.c to have only one promisor remote. - Patch 9/11: This adds test cases that shows that now more than one promisor remote can be used and that remote.<name>.promisor is set to "true" when fetching from a new promisor remote. - Patch 10/11 and 11/11: These are new documentation patches, to explain how things can work with more than one promisor remote. Links ~~~~~ This patch series on GitHub: V3: https://github.com/chriscool/git/commits/many-promisor-remotes V2: https://github.com/chriscool/git/commits/many-promisor-remotes35 V1: https://github.com/chriscool/git/commits/many-promisor-remotes17 On the mailing list: V2: https://firstname.lastname@example.org/ V1: https://email@example.com/ This patch series is a follow up from the discussions related to the remote odb V4 patch series: https://firstname.lastname@example.org/ Especially in: https://public-inbox.org/git/CAP8UFD3nrhjANwNDqTwx5ZtnZNcnbAFqUN=u=LrvzuH4+3wQQA@mail.gmail.com/ I said that I would like to work on things in the following order: 1) Teaching partial clone to attempt to fetch missing objects from multiple remotes instead of only one using the order in the config. 2) Simplifying the protocol for fetching missing objects so that it can be satisfied by a lighter weight object storage system than a full Git server. 3) Making it possible to explicitly define an order in which the remotes are accessed. 4) Making the criteria for what objects can be missing more aggressive, so that I can "git add" a large file and work with it using Git without even having a second copy of that object in my local object store. And this patch series is about the 1). The previous remote odb patch series on GitHub: V5: https://github.com/chriscool/git/commits/remote-odb V4: https://github.com/chriscool/git/commits/remote-odb5 V3: https://github.com/chriscool/git/commits/remote-odb3 V2: https://github.com/chriscool/git/commits/remote-odb2 V1: https://github.com/chriscool/git/commits/remote-odb1 Discussions related to previous versions of the odb patch series: V4: https://email@example.com/ V3: https://firstname.lastname@example.org/ V2: https://email@example.com/ V1: https://firstname.lastname@example.org/ Christian Couder (11): fetch-object: make functions return an error code Add initial support for many promisor remotes promisor-remote: implement promisor_remote_get_direct() promisor-remote: add promisor_remote_reinit() promisor-remote: use repository_format_partial_clone Use promisor_remote_get_direct() and has_promisor_remote() promisor-remote: parse remote.*.partialclonefilter builtin/fetch: remove unique promisor remote limitation t0410: test fetching from many promisor remotes partial-clone: add multiple remotes in the doc remote: add promisor and partial clone config to the doc Documentation/config/remote.txt | 8 ++ Documentation/technical/partial-clone.txt | 83 ++++++++---- Makefile | 1 + builtin/cat-file.c | 5 +- builtin/fetch.c | 29 ++--- builtin/gc.c | 3 +- builtin/repack.c | 3 +- cache-tree.c | 3 +- connected.c | 3 +- fetch-object.c | 13 +- fetch-object.h | 4 +- list-objects-filter-options.c | 51 ++++---- list-objects-filter-options.h | 3 +- packfile.c | 3 +- promisor-remote.c | 148 ++++++++++++++++++++++ promisor-remote.h | 22 ++++ sha1-file.c | 14 +- t/t0410-partial-clone.sh | 49 ++++++- t/t5601-clone.sh | 3 +- t/t5616-partial-clone.sh | 4 +- unpack-trees.c | 6 +- 21 files changed, 362 insertions(+), 96 deletions(-) create mode 100644 promisor-remote.c create mode 100644 promisor-remote.h -- 184.108.40.206.gb5e4dbcfd3
next reply other threads:[~2019-03-12 13:30 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-12 13:29 Christian Couder [this message] 2019-03-12 13:29 ` [PATCH v3 01/11] fetch-object: make functions return an error code Christian Couder 2019-03-12 13:29 ` [PATCH v3 02/11] Add initial support for many promisor remotes Christian Couder 2019-03-13 4:09 ` Junio C Hamano 2019-03-13 4:34 ` Junio C Hamano 2019-04-01 16:41 ` Christian Couder 2019-03-12 13:29 ` [PATCH v3 03/11] promisor-remote: implement promisor_remote_get_direct() Christian Couder 2019-03-13 4:23 ` Junio C Hamano 2019-04-01 16:41 ` Christian Couder 2019-03-12 13:29 ` [PATCH v3 04/11] promisor-remote: add promisor_remote_reinit() Christian Couder 2019-03-13 4:28 ` Junio C Hamano 2019-04-01 16:41 ` Christian Couder 2019-03-12 13:29 ` [PATCH v3 05/11] promisor-remote: use repository_format_partial_clone Christian Couder 2019-03-13 4:31 ` Junio C Hamano 2019-04-01 16:42 ` Christian Couder 2019-04-01 17:25 ` Junio C Hamano 2019-03-12 13:29 ` [PATCH v3 06/11] Use promisor_remote_get_direct() and has_promisor_remote() Christian Couder 2019-03-12 13:29 ` [PATCH v3 07/11] promisor-remote: parse remote.*.partialclonefilter Christian Couder 2019-03-12 13:29 ` [PATCH v3 08/11] builtin/fetch: remove unique promisor remote limitation Christian Couder 2019-03-12 13:29 ` [PATCH v3 09/11] t0410: test fetching from many promisor remotes Christian Couder 2019-03-12 13:29 ` [PATCH v3 10/11] partial-clone: add multiple remotes in the doc Christian Couder 2019-03-12 13:29 ` [PATCH v3 11/11] remote: add promisor and partial clone config to " Christian Couder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --cc=Ben.Peart@microsoft.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v3 00/11] Many promisor remotes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).