From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, philipoakley@iee.org, jrnieder@gmail.com,
avarab@gmail.com
Subject: Re: [PATCH v2] Configure Git contribution guidelines for github.com
Date: Wed, 14 Jun 2017 03:01:25 -0700 [thread overview]
Message-ID: <xmqqk24e51my.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <FEFF27D2-1A56-4F37-8114-126613C144A0@gmail.com> (Lars Schneider's message of "Wed, 14 Jun 2017 09:28:03 +0200")
Lars Schneider <larsxschneider@gmail.com> writes:
>> On 13 Jun 2017, at 11:04, Jeff King <peff@peff.net> wrote:
>>
>> On Tue, Jun 13, 2017 at 10:18:07AM +0200, Lars Schneider wrote:
>>
>>> changes since v1:
>>> * mention submitGit
>>> * link to mailing list address instead of mailing list archive
>>
>> You might want to link to https://git-scm.com/community/, which has a
>> section on the mailing list at the top. It gives the list address but
>> also talks about the archive, that you can send to it without
>> subscribing, etc.
>
> Agreed. I removed the mailing list email address as this is not
> useful until you have subscribed to the list.
Wait a minite. As Peff explained above, you *can* send to it
without subscribing, so "as this is not useful until you have
subscribed" is quite wrong, no?
>> The text itself looks good, but two minor grammar nits:
>> ...
>
> Agreed!
This I think I've already squashed in to v2 before pushing the
result out.
I do not terribly mind what you did in v3 to the list address,
and I do agree with Peff that mentioning the "community" page
is a good idea. But
Git community does not use github.com for their contributions. Instead, we use
a [mailing list](https://git-scm.com/community/) for code submissions,...
... and bug reports.
looks quite wrong. If it were
Git community does not use github.com for their contributions. Instead, we use
a [mailing list](mailto:git@vger.kernel.org) for code submissions,...
... and bug reports. See [the community page](https://git-scm.com/community/)
for further information.
I won't find it questionable at all, though.
next prev parent reply other threads:[~2017-06-14 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 8:18 [PATCH v2] Configure Git contribution guidelines for github.com Lars Schneider
2017-06-13 9:04 ` Jeff King
2017-06-14 7:28 ` Lars Schneider
2017-06-14 10:01 ` Junio C Hamano [this message]
2017-06-14 10:23 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk24e51my.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).