From: Lars Schneider <larsxschneider@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, gitster@pobox.com, philipoakley@iee.org,
jrnieder@gmail.com, avarab@gmail.com
Subject: Re: [PATCH v2] Configure Git contribution guidelines for github.com
Date: Wed, 14 Jun 2017 09:28:03 +0200 [thread overview]
Message-ID: <FEFF27D2-1A56-4F37-8114-126613C144A0@gmail.com> (raw)
In-Reply-To: <20170613090427.igjz7erniblh3wie@sigill.intra.peff.net>
> On 13 Jun 2017, at 11:04, Jeff King <peff@peff.net> wrote:
>
> On Tue, Jun 13, 2017 at 10:18:07AM +0200, Lars Schneider wrote:
>
>> changes since v1:
>> * mention submitGit
>> * link to mailing list address instead of mailing list archive
>
> You might want to link to https://git-scm.com/community/, which has a
> section on the mailing list at the top. It gives the list address but
> also talks about the archive, that you can send to it without
> subscribing, etc.
Agreed. I removed the mailing list email address as this is not
useful until you have subscribed to the list.
>
> The text itself looks good, but two minor grammar nits:
>
>> diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
>> new file mode 100644
>> index 0000000000..fc397bb8fc
>> --- /dev/null
>> +++ b/.github/CONTRIBUTING.md
>> @@ -0,0 +1,19 @@
>> +## Contributing to Git
>> +
>> +Thanks for taking the time to contribute to Git! Please be advised, that the
>> +Git community does not use github.com for their contributions. Instead, we use
>> +a mailing list (git@vger.kernel.org) for code submissions, code
>> +reviews, and bug reports.
>
> I think the comma after "advised" is unnecessary (you could also drop
> "that" to turn the first part into an introductory clause, but I think
> it reads better with as "Please be advised that").
Agreed!
Thank you,
Lars
next prev parent reply other threads:[~2017-06-14 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 8:18 [PATCH v2] Configure Git contribution guidelines for github.com Lars Schneider
2017-06-13 9:04 ` Jeff King
2017-06-14 7:28 ` Lars Schneider [this message]
2017-06-14 10:01 ` Junio C Hamano
2017-06-14 10:23 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FEFF27D2-1A56-4F37-8114-126613C144A0@gmail.com \
--to=larsxschneider@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).