Re: [PATCH v2] Configure Git contribution guidelines for github.com

[Lars Schneider <larsxschneider@gmail.com>]

> On 14 Jun 2017, at 12:01, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>>> On 13 Jun 2017, at 11:04, Jeff King <peff@peff.net> wrote:
>>> 
>>> On Tue, Jun 13, 2017 at 10:18:07AM +0200, Lars Schneider wrote:
>>> 
>>>> changes since v1:
>>>> * mention submitGit
>>>> * link to mailing list address instead of mailing list archive
>>> 
>>> You might want to link to https://git-scm.com/community/, which has a
>>> section on the mailing list at the top. It gives the list address but
>>> also talks about the archive, that you can send to it without
>>> subscribing, etc.
>> 
>> Agreed. I removed the mailing list email address as this is not
>> useful until you have subscribed to the list.
> 
> Wait a minite.  As Peff explained above, you *can* send to it
> without subscribing, so "as this is not useful until you have
> subscribed" is quite wrong, no?

Oh, I didn't know that! I "subscribed" before sending my first
message :)


> 
>>> The text itself looks good, but two minor grammar nits:
>>> ... 
>> 
>> Agreed!
> 
> This I think I've already squashed in to v2 before pushing the
> result out.
> 
> I do not terribly mind what you did in v3 to the list address,
> and I do agree with Peff that mentioning the "community" page
> is a good idea.  But
> 
>     Git community does not use github.com for their contributions. Instead, we use
>     a [mailing list](https://git-scm.com/community/) for code submissions,...
>     ... and bug reports.
> 
> looks quite wrong.  If it were
> 
>     Git community does not use github.com for their contributions. Instead, we use
>     a [mailing list](mailto:git@vger.kernel.org) for code submissions,...
>     ... and bug reports.  See [the community page](https://git-scm.com/community/)
>     for further information.

Looks good to me (minor nit: maybe s/the community page/our community page/ for a
more personal touch?). However, I would apply these changes only to CONTRIBUTING.md.
Markdown links wouldn't work in PULL_REQUEST_TEMPLATE.md as the user would see
the Markdown in plain text and not rendered.

Example here:
https://github.com/larsxschneider/git/compare/master...larsxschneider-patch-1?quick_pull=1

Thanks,
Lars