From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Christian Hesse <list@eworm.de>,
Git Mailing List <git@vger.kernel.org>,
Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] subtree: make install targets depend on build targets
Date: Thu, 18 Oct 2018 11:05:07 +0900 [thread overview]
Message-ID: <xmqqk1mgvwks.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181017024503.GA117170@aiede.svl.corp.google.com> (Jonathan Nieder's message of "Tue, 16 Oct 2018 19:45:03 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> -install-html: $(GIT_SUBTREE_HTML)
>> +install-html: html
>
> This broke the build for me:
>
> make[2]: Entering directory '/build/git-2.19.1+next.20181016/contrib/subtree'
> install -m 644 html /build/git-2.19.1+next.20181016/debian/tmp/usr/share/doc/git/html
> install: cannot stat 'html': No such file or directory
> make[2]: *** [Makefile:78: install-html] Error 1
>
> The rule says
>
> install-html: html
> $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir)
> $(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir)
>
> and $^ substitutes to "html" after this change. How was this patch
> tested?
Gah, that was silly of me.
next prev parent reply other threads:[~2018-10-18 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 7:30 [PATCH 1/1] subtree: add build targets 'man' and 'html' Christian Hesse
2018-10-10 2:26 ` Junio C Hamano
2018-10-12 8:08 ` Johannes Schindelin
2018-10-15 21:15 ` Christian Hesse
2018-10-16 2:05 ` Junio C Hamano
2018-10-16 5:01 ` Junio C Hamano
2018-10-16 7:56 ` [PATCH 1/1] subtree: make install targets depend on build targets Christian Hesse
2018-10-16 8:00 ` Junio C Hamano
2018-10-17 2:45 ` Jonathan Nieder
2018-10-18 2:05 ` Junio C Hamano [this message]
2018-10-18 2:09 ` Junio C Hamano
2018-10-18 8:05 ` Christian Hesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1mgvwks.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=list@eworm.de \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).