From: Junio C Hamano <gitster@pobox.com>
To: Christian Hesse <list@eworm.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] subtree: add build targets 'man' and 'html'
Date: Tue, 16 Oct 2018 14:01:01 +0900 [thread overview]
Message-ID: <xmqq8t2y1o4y.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqq1s8q4pen.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Tue, 16 Oct 2018 11:05:20 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Christian Hesse <list@eworm.de> writes:
>
>> Junio C Hamano <gitster@pobox.com> on Wed, 2018/10/10 11:26:
>>> As 'contrib' material without real maintenance, I do not care too
>>> deeply, but shouldn't this change be more like this to avoid
>>> duplicating the list of targets?
>>
>> Probably, yes.
>> Do you want to add this yourself or do you want me to send an updated patch
>> or one on top of the last change?
>
> In principle either is fine but keep in mind that I'll likely forget
> if you leave it up to me.
Actully, I take it back. The original patch is already in 'next',
so an incremental on top of what you sent is the only valid
improvement ;-)
next prev parent reply other threads:[~2018-10-16 5:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 7:30 [PATCH 1/1] subtree: add build targets 'man' and 'html' Christian Hesse
2018-10-10 2:26 ` Junio C Hamano
2018-10-12 8:08 ` Johannes Schindelin
2018-10-15 21:15 ` Christian Hesse
2018-10-16 2:05 ` Junio C Hamano
2018-10-16 5:01 ` Junio C Hamano [this message]
2018-10-16 7:56 ` [PATCH 1/1] subtree: make install targets depend on build targets Christian Hesse
2018-10-16 8:00 ` Junio C Hamano
2018-10-17 2:45 ` Jonathan Nieder
2018-10-18 2:05 ` Junio C Hamano
2018-10-18 2:09 ` Junio C Hamano
2018-10-18 8:05 ` Christian Hesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8t2y1o4y.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=list@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).