From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Hesse <list@eworm.de>,
Git Mailing List <git@vger.kernel.org>,
Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] subtree: add build targets 'man' and 'html'
Date: Fri, 12 Oct 2018 10:08:12 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1810121006180.45@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqmurmmt9j.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]
On Wed, 10 Oct 2018, Junio C Hamano wrote:
> Christian Hesse <list@eworm.de> writes:
>
> > From: Christian Hesse <mail@eworm.de>
> >
> > We have targets 'install-man' and 'install-html', let's add build
> > targets as well.
> > ...
> > +man: $(GIT_SUBTREE_DOC)
> > +
> > +html: $(GIT_SUBTREE_HTML)
> > +
>
> As 'contrib' material without real maintenance, I do not care too
> deeply, but shouldn't this change be more like this to avoid
> duplicating the list of targets?
Ævar mentioned that he'd like this to graduate from contrib into core, and
I had briefly looked at making subtree a built-in to that end. IOW please
do not get too used to subtree being in contrib.
Ciao,
Dscho
>
>
> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index 5c6cc4ab2c..4a10a020a0 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -59,17 +59,21 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)
>
> doc: $(GIT_SUBTREE_DOC) $(GIT_SUBTREE_HTML)
>
> +man: $(GIT_SUBTREE_DOC)
> +
> +html: $(GIT_SUBTREE_HTML)
> +
> install: $(GIT_SUBTREE)
> $(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)
> $(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(gitexecdir)
>
> install-doc: install-man install-html
>
> -install-man: $(GIT_SUBTREE_DOC)
> +install-man: man
> $(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)
> $(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)
>
> -install-html: $(GIT_SUBTREE_HTML)
> +install-html: html
> $(INSTALL) -d -m 755 $(DESTDIR)$(htmldir)
> $(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir)
>
> @@ -94,4 +98,4 @@ clean:
> $(RM) $(GIT_SUBTREE)
> $(RM) *.xml *.html *.1
>
> -.PHONY: FORCE
> +.PHONY: FORCE man html install-man install-html
>
>
next prev parent reply other threads:[~2018-10-12 8:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 7:30 [PATCH 1/1] subtree: add build targets 'man' and 'html' Christian Hesse
2018-10-10 2:26 ` Junio C Hamano
2018-10-12 8:08 ` Johannes Schindelin [this message]
2018-10-15 21:15 ` Christian Hesse
2018-10-16 2:05 ` Junio C Hamano
2018-10-16 5:01 ` Junio C Hamano
2018-10-16 7:56 ` [PATCH 1/1] subtree: make install targets depend on build targets Christian Hesse
2018-10-16 8:00 ` Junio C Hamano
2018-10-17 2:45 ` Jonathan Nieder
2018-10-18 2:05 ` Junio C Hamano
2018-10-18 2:09 ` Junio C Hamano
2018-10-18 8:05 ` Christian Hesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1810121006180.45@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=list@eworm.de \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).