* [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
@ 2018-07-25 10:12 Daniel Baumann
2018-07-25 10:54 ` Ævar Arnfjörð Bjarmason
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Baumann @ 2018-07-25 10:12 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
Hi,
the attached patch removes a superfluous tab indentation in the
interactive git-rebase messages.
It would be nice to get rid of this to avoid visual disturbance with
whitespace highlighting editors.
Regards,
Daniel
[-- Attachment #2: 0001-git-rebase-interactive.sh-Remove-superfluous-tab-in-.patch --]
[-- Type: text/x-patch, Size: 930 bytes --]
From 353eb1c2c44d5117a3fad1323ca6852b13e4c86a Mon Sep 17 00:00:00 2001
From: Daniel Baumann <mail@daniel-baumann.ch>
Date: Wed, 25 Jul 2018 11:58:40 +0200
Subject: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
file
Removing superfluous tab indentation in interactive git-rebase
file to avoid visual disturbance with whitespace highlighting editors.
Signed-off-by: Daniel Baumann <mail@daniel-baumann.ch>
---
git-rebase--interactive.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 299ded213..0bf9eefad 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -224,7 +224,7 @@ EOF
gettext "
However, if you remove everything, the rebase will be aborted.
- " | git stripspace --comment-lines >>"$todo"
+" | git stripspace --comment-lines >>"$todo"
if test -z "$keep_empty"
then
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
2018-07-25 10:12 [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase Daniel Baumann
@ 2018-07-25 10:54 ` Ævar Arnfjörð Bjarmason
2018-07-26 2:21 ` Daniel Baumann
0 siblings, 1 reply; 4+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2018-07-25 10:54 UTC (permalink / raw)
To: mail; +Cc: git, Alban Gruin
On Wed, Jul 25 2018, Daniel Baumann wrote:
> the attached patch removes a superfluous tab indentation in the
> interactive git-rebase messages.
>
> It would be nice to get rid of this to avoid visual disturbance with
> whitespace highlighting editors.
The code you're modifying doesn't exist in the "pu" branch since
249d626f2c ("rebase--interactive: rewrite append_todo_help() in C",
2018-07-10), rebase is being rewritten in C. From looking at it it seems
we no longer have this problem, but perhaps you'd like to check that out
for yourself?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
2018-07-25 10:54 ` Ævar Arnfjörð Bjarmason
@ 2018-07-26 2:21 ` Daniel Baumann
2018-07-26 4:16 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Baumann @ 2018-07-26 2:21 UTC (permalink / raw)
To: git
Hi,
On 07/25/2018 12:54 PM, Ævar Arnfjörð Bjarmason wrote:
> The code you're modifying doesn't exist in the "pu" branch since
> 249d626f2c
indeed, thanks.
> From looking at it it seems we no longer have this problem,
> but perhaps you'd like to check that out for yourself?
Yes, it's not needed anymore at all, yay!
Sorry for the noise.
Regards,
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
2018-07-26 2:21 ` Daniel Baumann
@ 2018-07-26 4:16 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2018-07-26 4:16 UTC (permalink / raw)
To: Daniel Baumann; +Cc: git
Daniel Baumann <mail@daniel-baumann.ch> writes:
> On 07/25/2018 12:54 PM, Ævar Arnfjörð Bjarmason wrote:
>> The code you're modifying doesn't exist in the "pu" branch since
>> 249d626f2c
>
> indeed, thanks.
>
>> From looking at it it seems we no longer have this problem,
>> but perhaps you'd like to check that out for yourself?
> Yes, it's not needed anymore at all, yay!
>
> Sorry for the noise.
Thanks for reporting. It is 100% better to see occasional
duplicates than nothing.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-26 4:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 10:12 [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase Daniel Baumann
2018-07-25 10:54 ` Ævar Arnfjörð Bjarmason
2018-07-26 2:21 ` Daniel Baumann
2018-07-26 4:16 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).