git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: mail@daniel-baumann.ch
Cc: git@vger.kernel.org, Alban Gruin <alban.gruin@gmail.com>
Subject: Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
Date: Wed, 25 Jul 2018 12:54:26 +0200	[thread overview]
Message-ID: <87o9evbn6l.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <db70d275-584e-3a3b-5201-dc04e4c5950b@daniel-baumann.ch>


On Wed, Jul 25 2018, Daniel Baumann wrote:

> the attached patch removes a superfluous tab indentation in the
> interactive git-rebase messages.
>
> It would be nice to get rid of this to avoid visual disturbance with
> whitespace highlighting editors.

The code you're modifying doesn't exist in the "pu" branch since
249d626f2c ("rebase--interactive: rewrite append_todo_help() in C",
2018-07-10), rebase is being rewritten in C. From looking at it it seems
we no longer have this problem, but perhaps you'd like to check that out
for yourself?

  reply	other threads:[~2018-07-25 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 10:12 [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase Daniel Baumann
2018-07-25 10:54 ` Ævar Arnfjörð Bjarmason [this message]
2018-07-26  2:21   ` Daniel Baumann
2018-07-26  4:16     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9evbn6l.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=alban.gruin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mail@daniel-baumann.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).