From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Randall Becker <rsbecker@nexbridge.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] tests: teach the test-tool to generate NUL bytes and use it
Date: Thu, 14 Feb 2019 14:13:49 -0800 [thread overview]
Message-ID: <xmqqimxm6msi.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <34cde0f2849a098c17ab83786da5ce06f69cfafa.1550179990.git.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Thu, 14 Feb 2019 13:33:12 -0800 (PST)")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In cc95bc2025 (t5562: replace /dev/zero with a pipe from
> generate_zero_bytes, 2019-02-09), we replaced usage of /dev/zero (which
> is not available on NonStop, apparently) by a Perl script snippet to
> generate NUL bytes.
>
> Sadly, it does not seem to work on NonStop, as t5562 reportedly hangs.
> ...
> In the end, though, what counts is that this here change incidentally
> fixes that hang (maybe also on NonStop?). Even more positively, it gets
> rid of yet another unnecessary Perl invocation.
Thanks for a quick band-aid.
Will apply directly to 'master' so that we won't forget before -rc2.
In the meantime, perhaps somebody who knows Perl interpreter's
quirks well can tell us what's different between the obvious and
simple C program and an equivalent in Perl to convince us why this
is a good solution to the problem.
next prev parent reply other threads:[~2019-02-14 22:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 21:33 [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1 Johannes Schindelin via GitGitGadget
2019-02-14 21:33 ` [PATCH 1/1] tests: teach the test-tool to generate NUL bytes and use it Johannes Schindelin via GitGitGadget
2019-02-14 22:13 ` Junio C Hamano [this message]
2019-02-15 14:59 ` Johannes Schindelin
2019-02-15 17:41 ` Junio C Hamano
2019-02-18 15:55 ` Johannes Schindelin
2019-02-14 22:17 ` [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1 Randall S. Becker
2019-02-14 22:33 ` Max Kirillov
2019-02-14 22:59 ` Randall S. Becker
2019-02-14 23:04 ` Randall S. Becker
2019-02-14 22:38 ` Junio C Hamano
2019-02-14 23:01 ` Randall S. Becker
2019-02-18 20:41 ` Johannes Schindelin
2019-02-18 20:46 ` Randall S. Becker
2019-02-18 20:57 ` Max Kirillov
2019-02-19 14:09 ` Johannes Schindelin
2019-02-18 20:57 ` Randall S. Becker
2019-02-18 21:49 ` Randall S. Becker
2019-02-18 21:06 ` Ævar Arnfjörð Bjarmason
2019-02-18 21:17 ` Max Kirillov
2019-02-19 14:13 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimxm6msi.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).