git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Max Kirillov <max@max630.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"Randall S. Becker" <rsbecker@nexbridge.com>,
	'Johannes Schindelin via GitGitGadget'  <gitgitgadget@gmail.com>,
	git@vger.kernel.org, 'Max Kirillov' <max@max630.net>
Subject: Re: [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1
Date: Mon, 18 Feb 2019 23:17:25 +0200	[thread overview]
Message-ID: <20190218211725.GD3373@jessie.local> (raw)
In-Reply-To: <87pnroolgy.fsf@evledraar.gmail.com>

On Mon, Feb 18, 2019 at 10:06:21PM +0100, Ævar Arnfjörð Bjarmason wrote:
>> But in our attempt to exit(), we try to "cleanup children" and that
>> is what gets stuck.
> 
> I have not paid enough attention to this thread to say if this is dumb,
> but just in case it's useful. For this class of problem where cleanup
> bites you for whatever reason in Perl, you can sometimes use this:
> 
>     use POSIX ();
>     POSIX::_exit($code);
> 
> This will call "exit" from "stdlib" instead of Perl's "exit". So go away
> *now* and let the OS deal with the mess. Perl's will run around cleaning
> up stuff, freeing memory, running destructors etc, all of which might
> have side effects you don't want/care about, and might (as maybe in this
> case?) cause some hang.

* Perl is running in foreground, so it cannot outlive test
  case and spoil the subsequent ones.
* From the dumps I have an impression that it waits
  legitimately - there are other processes to wait for.
  And anyway the waits happen before perl script comes to
  its exit.

Though I am already convinced that I should have done the
helper in C. Let's see when I have time to fix it.

  reply	other threads:[~2019-02-18 21:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 21:33 [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1 Johannes Schindelin via GitGitGadget
2019-02-14 21:33 ` [PATCH 1/1] tests: teach the test-tool to generate NUL bytes and use it Johannes Schindelin via GitGitGadget
2019-02-14 22:13   ` Junio C Hamano
2019-02-15 14:59     ` Johannes Schindelin
2019-02-15 17:41       ` Junio C Hamano
2019-02-18 15:55         ` Johannes Schindelin
2019-02-14 22:17 ` [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1 Randall S. Becker
2019-02-14 22:33   ` Max Kirillov
2019-02-14 22:59     ` Randall S. Becker
2019-02-14 23:04     ` Randall S. Becker
2019-02-14 22:38   ` Junio C Hamano
2019-02-14 23:01     ` Randall S. Becker
2019-02-18 20:41       ` Johannes Schindelin
2019-02-18 20:46         ` Randall S. Becker
2019-02-18 20:57           ` Max Kirillov
2019-02-19 14:09             ` Johannes Schindelin
2019-02-18 20:57           ` Randall S. Becker
2019-02-18 21:49         ` Randall S. Becker
2019-02-18 21:06     ` Ævar Arnfjörð Bjarmason
2019-02-18 21:17       ` Max Kirillov [this message]
2019-02-19 14:13         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218211725.GD3373@jessie.local \
    --to=max@max630.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).