From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Max Kirillov <max@max630.net>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
'Junio C Hamano' <gitster@pobox.com>,
'Johannes Schindelin via GitGitGadget' <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1
Date: Tue, 19 Feb 2019 15:09:15 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1902191507380.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20190218205725.GB3373@jessie.local>
Hi Max & Randall,
On Mon, 18 Feb 2019, Max Kirillov wrote:
> On Mon, Feb 18, 2019 at 03:46:34PM -0500, Randall S. Becker wrote:
> > On February 18, 2019 15:41, Johannes Schindelin wrote:
> > > So could you try with this patch?
> > >
> > > -- snipsnap --
> > > diff --git a/http-backend.c b/http-backend.c index d5cea0329a..7c1b4a2555
> > > 100644
> > > --- a/http-backend.c
> > > +++ b/http-backend.c
> > > @@ -427,6 +427,7 @@ static void inflate_request(const char *prog_name,
> > > int out, int buffer_input, ss
> > >
> > > done:
> > > git_inflate_end(&stream);
> > > + close(0);
> > > close(out);
> > > free(full_request);
> > > }
> >
> > In isolation or with the other fixes associated with t5562? Or, which
> > baseline commit should I use? 8989e1950a or d92031209a or some other?
>
> As far as I understand, it should be tried instead of
> https://public-inbox.org/git/20181124093719.10705-1-max@max630.net/
Don't ask me which patches you need to try this with. I was just answering
to the observation that the hangs happen in the gzip-encoding test cases,
and this was my guess as to what is going wrong there. I have no idea
whether other patches try to address the same thing, are obsoleted by this
diff, or whatever, as I have not been able to pay attention to the Git
mailing list in the past 5 days.
Ciao,
Johannes
next prev parent reply other threads:[~2019-02-19 14:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 21:33 [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1 Johannes Schindelin via GitGitGadget
2019-02-14 21:33 ` [PATCH 1/1] tests: teach the test-tool to generate NUL bytes and use it Johannes Schindelin via GitGitGadget
2019-02-14 22:13 ` Junio C Hamano
2019-02-15 14:59 ` Johannes Schindelin
2019-02-15 17:41 ` Junio C Hamano
2019-02-18 15:55 ` Johannes Schindelin
2019-02-14 22:17 ` [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1 Randall S. Becker
2019-02-14 22:33 ` Max Kirillov
2019-02-14 22:59 ` Randall S. Becker
2019-02-14 23:04 ` Randall S. Becker
2019-02-14 22:38 ` Junio C Hamano
2019-02-14 23:01 ` Randall S. Becker
2019-02-18 20:41 ` Johannes Schindelin
2019-02-18 20:46 ` Randall S. Becker
2019-02-18 20:57 ` Max Kirillov
2019-02-19 14:09 ` Johannes Schindelin [this message]
2019-02-18 20:57 ` Randall S. Becker
2019-02-18 21:49 ` Randall S. Becker
2019-02-18 21:06 ` Ævar Arnfjörð Bjarmason
2019-02-18 21:17 ` Max Kirillov
2019-02-19 14:13 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1902191507380.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=max@max630.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).