From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems
Date: Mon, 24 Jun 2019 10:09:26 -0700 [thread overview]
Message-ID: <xmqqimsuj4ft.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1906241212220.44@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 24 Jun 2019 12:13:44 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> I wonder if we want (possibly local) test_cmp_fspath that can be
>> used more like
>>
>> test_cmp_fspath "$(pwd)/realgitdir" "$(sed -e "s/^gitdir: //" newdir/.git)"
>>
>> to compare two paths, honoring the case sensitivity of the
>> filesystem.
>
> I agree that that's a much better approach to fix the issue.
I find that response somewhat surprising :-|. In any case, I am not
sure what kind of 'path' other than the filesystem one we would deal
with in the context of Git and its test suite, so perhaps we should
drop 'fs' from the name of the helper function if we were to go that
route.
next prev parent reply other threads:[~2019-06-24 17:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 14:43 [PATCH 0/1] Fix a test on NTFS (and probably HFS+) Johannes Schindelin via GitGitGadget
2019-06-08 14:43 ` [PATCH 1/1] t0001: fix on case-insensitive filesystems Johannes Schindelin via GitGitGadget
2019-06-09 19:23 ` Martin Ågren
2019-06-19 20:24 ` Johannes Schindelin
2019-06-09 20:13 ` brian m. carlson
2019-06-10 16:32 ` Junio C Hamano
2019-06-19 20:17 ` Johannes Schindelin
2019-06-21 19:33 ` Ævar Arnfjörð Bjarmason
[not found] ` <pull.151.v2.git.gitgitgadget@gmail.com>
[not found] ` <c2fdcf28e725c91a1a48c34226223866ad14bc0a.1560978437.git.gitgitgadget@gmail.com>
2019-06-21 14:34 ` [PATCH v2 " Johannes Schindelin
2019-06-21 17:31 ` Junio C Hamano
2019-06-24 10:13 ` Johannes Schindelin
2019-06-24 17:09 ` Junio C Hamano [this message]
2019-06-24 17:38 ` Johannes Schindelin
2019-06-24 19:22 ` Junio C Hamano
[not found] ` <pull.151.v3.git.gitgitgadget@gmail.com>
[not found] ` <1f0ceee8687e9032a7777f764b34b1c9ccc68f38.1561379363.git.gitgitgadget@gmail.com>
2019-06-24 17:40 ` [PATCH v3 " Johannes Schindelin
2019-06-24 18:55 ` Junio C Hamano
2019-06-25 10:50 ` vger vs GitGitGadget, was " Johannes Schindelin
2019-06-25 19:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimsuj4ft.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=martin.agren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).